diff options
| author | Mark Geisert <mark@maxrnd.com> | 2021-02-10 22:53:05 -0800 |
|---|---|---|
| committer | Corinna Vinschen <corinna@vinschen.de> | 2021-02-12 10:18:25 +0100 |
| commit | 62ee6581a5701342c17790116f847e9d40c387d7 (patch) | |
| tree | 44152f02a944933cde5be71c6e717cd77452c97e | |
| parent | 5fea2f87dcb4d64f25072cc66d8909c7945e2345 (diff) | |
| download | cygnal-62ee6581a5701342c17790116f847e9d40c387d7.tar.gz cygnal-62ee6581a5701342c17790116f847e9d40c387d7.tar.bz2 cygnal-62ee6581a5701342c17790116f847e9d40c387d7.zip | |
Cygwin: Have tmpfile(3) use O_TMPFILE
Per discussion on cygwin-developers, a Cygwin tmpfile(3) implementation
has been added to syscalls.cc. This overrides the one supplied by
newlib. Then the open(2) flag O_TMPFILE was added to the open call that
tmpfile internally makes.
This v2 patch removes O_CREAT from open() call as O_TMPFILE obviates it.
Note that open() takes a directory's path but returns an fd to a file.
| -rw-r--r-- | winsup/cygwin/release/3.2.0 | 4 | ||||
| -rw-r--r-- | winsup/cygwin/syscalls.cc | 19 |
2 files changed, 23 insertions, 0 deletions
diff --git a/winsup/cygwin/release/3.2.0 b/winsup/cygwin/release/3.2.0 index f748a9bc8..d02d16863 100644 --- a/winsup/cygwin/release/3.2.0 +++ b/winsup/cygwin/release/3.2.0 @@ -19,6 +19,10 @@ What changed: - A few FAQ updates. +- Have tmpfile(3) make use of Win32 FILE_ATTRIBUTE_TEMPORARY via open(2) + flag O_TMPFILE. + Addresses: https://cygwin.com/pipermail/cygwin/2021-January/247304.html + Bug Fixes --------- diff --git a/winsup/cygwin/syscalls.cc b/winsup/cygwin/syscalls.cc index 52a020f07..d04b2d9b3 100644 --- a/winsup/cygwin/syscalls.cc +++ b/winsup/cygwin/syscalls.cc @@ -5225,3 +5225,22 @@ pipe2 (int filedes[2], int mode) syscall_printf ("%R = pipe2([%d, %d], %y)", res, read, write, mode); return res; } + +extern "C" FILE * +tmpfile (void) +{ + char *dir = getenv ("TMPDIR"); + if (!dir) + dir = P_tmpdir; + int fd = open (dir, O_RDWR | O_BINARY | O_TMPFILE, S_IRUSR | S_IWUSR); + if (fd < 0) + return NULL; + FILE *fp = fdopen (fd, "wb+"); + int e = errno; + if (!fp) + close (fd); // ..will remove tmp file + set_errno (e); + return fp; +} + +EXPORT_ALIAS (tmpfile, tmpfile64) |