diff options
| author | Ken Brown <kbrown@cornell.edu> | 2020-01-24 14:54:47 -0500 |
|---|---|---|
| committer | Ken Brown <kbrown@cornell.edu> | 2020-01-28 14:05:13 -0500 |
| commit | 74e6e881433c45e758582adfdcb4be20ad5b52a9 (patch) | |
| tree | 80781d7697adfd0fa0986347efd3b977fd78a3e5 | |
| parent | 4bfa93f1a00a09e4fb3bccea334ba22e4c05c3d6 (diff) | |
| download | cygnal-74e6e881433c45e758582adfdcb4be20ad5b52a9.tar.gz cygnal-74e6e881433c45e758582adfdcb4be20ad5b52a9.tar.bz2 cygnal-74e6e881433c45e758582adfdcb4be20ad5b52a9.zip | |
Cygwin: fhandler_base::fstat_fs: accomodate the O_PATH flag
Treat a special file opened with O_PATH the same as a regular file,
i.e., use its handle to get the stat information.
Before this change, fstat_fs opened the file a second time, with the
wrong flags and without closing the existing handle. A side effect
was to change the openflags of the file, possibly causing further
system calls to fail.
Currently this change only affects FIFOs, but it will affect
AF_LOCAL/AF_UNIX sockets too once they support O_PATH.
| -rw-r--r-- | winsup/cygwin/fhandler_disk_file.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/winsup/cygwin/fhandler_disk_file.cc b/winsup/cygwin/fhandler_disk_file.cc index 197f04f58..d9213d741 100644 --- a/winsup/cygwin/fhandler_disk_file.cc +++ b/winsup/cygwin/fhandler_disk_file.cc @@ -359,7 +359,7 @@ fhandler_base::fstat_fs (struct stat *buf) if (get_stat_handle ()) { - if (!nohandle () && !is_fs_special ()) + if (!nohandle () && (!is_fs_special () || get_flags () & O_PATH)) res = pc.fs_is_nfs () ? fstat_by_nfs_ea (buf) : fstat_by_handle (buf); if (res) res = fstat_by_name (buf); |