diff options
| author | Ken Brown <kbrown@cornell.edu> | 2020-10-27 09:52:48 -0400 |
|---|---|---|
| committer | Ken Brown <kbrown@cornell.edu> | 2020-10-27 10:23:27 -0400 |
| commit | 262de3ecf08e8981a2b2d5949a3d31c613a36b2b (patch) | |
| tree | 2a33bdcedfbc6217f7d3546d5b71f165795eb769 | |
| parent | 490d4862df73ffba39ba7d82c4b65c539d5e33f6 (diff) | |
| download | cygnal-262de3ecf08e8981a2b2d5949a3d31c613a36b2b.tar.gz cygnal-262de3ecf08e8981a2b2d5949a3d31c613a36b2b.tar.bz2 cygnal-262de3ecf08e8981a2b2d5949a3d31c613a36b2b.zip | |
Cygwin: fix return value of sqrtl on negative infinity
The return value is now -NaN.
This fixes a bug in the mingw-w64 code that was imported into Cygwin.
The fix is consistent with Posix and Linux. It is also consistent
with the current mingw-w64 code, with one exception: The mingw-w64
code sets errno to EDOM if the input is -NaN, but this appears to
differ from Posix and Linux.
Addresses: https://cygwin.com/pipermail/cygwin/2020-October/246606.html
| -rw-r--r-- | winsup/cygwin/math/sqrt.def.h | 5 | ||||
| -rw-r--r-- | winsup/cygwin/release/3.2.0 | 5 |
2 files changed, 8 insertions, 2 deletions
diff --git a/winsup/cygwin/math/sqrt.def.h b/winsup/cygwin/math/sqrt.def.h index cf8b5cbe6..3d1a00908 100644 --- a/winsup/cygwin/math/sqrt.def.h +++ b/winsup/cygwin/math/sqrt.def.h @@ -73,8 +73,11 @@ __FLT_ABI (sqrt) (__FLT_TYPE x) if (x_class == FP_ZERO) return __FLT_CST (-0.0); + if (x_class == FP_NAN) + return x; + errno = EDOM; - return x; + return -__FLT_NAN; } else if (x_class == FP_ZERO) return __FLT_CST (0.0); diff --git a/winsup/cygwin/release/3.2.0 b/winsup/cygwin/release/3.2.0 index 11de87dbc..22f78e7a7 100644 --- a/winsup/cygwin/release/3.2.0 +++ b/winsup/cygwin/release/3.2.0 @@ -37,5 +37,8 @@ Bug Fixes - Fix assertion failure on an invalid path under /proc/<pid>/fd/. Addresses: https://cygwin.com/pipermail/cygwin/2020-September/246160.html -- Fix crash on stat(2)'ing /dev/ptmx on 32 bit +- Fix crash on stat(2)'ing /dev/ptmx on 32 bit. Addresses: https://cygwin.com/pipermail/cygwin/2020-September/246218.html + +- Fix return value of sqrtl on negative infinity. + Addresses: https://cygwin.com/pipermail/cygwin/2020-October/246606.html |