summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorCorinna Vinschen <corinna@vinschen.de>2013-05-24 13:43:26 +0000
committerCorinna Vinschen <corinna@vinschen.de>2013-05-24 13:43:26 +0000
commit6184e6b9c81b42960d8e352d38af860e2a9495ab (patch)
treef979bd4db6f89a7851be74c6f55cbb71a9d6812d
parent1a5dfe8ae08e00200a081f1f1a368f1201543761 (diff)
downloadcygnal-6184e6b9c81b42960d8e352d38af860e2a9495ab.tar.gz
cygnal-6184e6b9c81b42960d8e352d38af860e2a9495ab.tar.bz2
cygnal-6184e6b9c81b42960d8e352d38af860e2a9495ab.zip
* pinfo.cc (pinfo::status_exit): Enhance comment.
-rw-r--r--winsup/cygwin/ChangeLog4
-rw-r--r--winsup/cygwin/pinfo.cc6
2 files changed, 7 insertions, 3 deletions
diff --git a/winsup/cygwin/ChangeLog b/winsup/cygwin/ChangeLog
index 1fce36c35..481e20264 100644
--- a/winsup/cygwin/ChangeLog
+++ b/winsup/cygwin/ChangeLog
@@ -1,5 +1,9 @@
2013-05-24 Corinna Vinschen <corinna@vinschen.de>
+ * pinfo.cc (pinfo::status_exit): Enhance comment.
+
+2013-05-24 Corinna Vinschen <corinna@vinschen.de>
+
* environ.cc (win_env::add_cache): Set the Windows environment variable
using wide chars to make sure native chars don't get scrambled.
* environ.h (build_env): Fix formatting in declaration.
diff --git a/winsup/cygwin/pinfo.cc b/winsup/cygwin/pinfo.cc
index c51902cbd..51d01322c 100644
--- a/winsup/cygwin/pinfo.cc
+++ b/winsup/cygwin/pinfo.cc
@@ -149,9 +149,9 @@ pinfo::status_exit (DWORD x)
Windows environment is > 32K, startup of an exec'ed process fails with
STATUS_NO_MEMORY. This happens with all Cygwin executables, as well
as, for instance, notepad, but it does not happen with CMD for some
- reason. This occurs at a point where there's no return to the exec'ing
- parent process, so we have to find some way to inform the user what
- happened.
+ reason (but note, the environment *in* CMD is broken and shortened).
+ This occurs at a point where there's no return to the exec'ing parent
+ process, so we have to find some way to inform the user what happened.
FIXME: For now, just return with SIGBUS set. Maybe it's better to add
a lengthy small_printf instead. */