summaryrefslogtreecommitdiffstats
path: root/winsup/cygwin/thread.cc
diff options
context:
space:
mode:
authorCorinna Vinschen <corinna@vinschen.de>2012-05-22 10:28:05 +0000
committerCorinna Vinschen <corinna@vinschen.de>2012-05-22 10:28:05 +0000
commit601431090344d2db08f9f19b30a8affb05a7ce0c (patch)
tree7e0c24b4ea169fa4f2a07148251da2476526950b /winsup/cygwin/thread.cc
parent08d7e0c909744035300379edcc3e74d0184b3e30 (diff)
downloadcygnal-601431090344d2db08f9f19b30a8affb05a7ce0c.tar.gz
cygnal-601431090344d2db08f9f19b30a8affb05a7ce0c.tar.bz2
cygnal-601431090344d2db08f9f19b30a8affb05a7ce0c.zip
* thread.cc (pthread::cancel): Set thread's cancel_event in
PTHREAD_CANCEL_ASYNCHRONOUS case, too. Explain why.
Diffstat (limited to 'winsup/cygwin/thread.cc')
-rw-r--r--winsup/cygwin/thread.cc12
1 files changed, 12 insertions, 0 deletions
diff --git a/winsup/cygwin/thread.cc b/winsup/cygwin/thread.cc
index 1bea526bf..f7ba60a70 100644
--- a/winsup/cygwin/thread.cc
+++ b/winsup/cygwin/thread.cc
@@ -566,6 +566,18 @@ pthread::cancel ()
SetThreadContext (win32_obj_id, &context);
}
mutex.unlock ();
+ /* Setting the context to another function does not work if the thread is
+ waiting in WFMO. For instance, a thread which waits for a semaphore in
+ sem_wait will call cancelable_wait which in turn calls WFMO. While this
+ WFMO call is cancelable by setting the thread's cancel_event object, the
+ OS apparently refuses to set the thread's context and continues to wait
+ for the WFMO conditions. This is *not* reflected in the return value of
+ SetThreadContext or ResumeThread, btw.
+ So, what we do here is to set the cancel_event as well. This allows the
+ WFMO call in cancelable_wait and elsewhere to return and to handle the
+ cancel request by itself. */
+ canceled = true;
+ SetEvent (cancel_event);
ResumeThread (win32_obj_id);
return 0;