summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Cygwin: serial: avoid overrun of vtimeCorinna Vinschen2020-03-221-4/+4
| | | | | | | After changing the type of fhandler_serial::vtime_ to cc_t, vtime_ must be stored in 10s of seconds, not in milliseconds. Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
* Cygwin: serial: select: fix previous revamp patchÅke Rehnman2020-03-222-4/+9
| | | | | | - We need a verify function. - The event object referenced in WaitCommEvent must not be a local var, move it into fhandler_serial.
* Cygwin: serial: revamp overlapped IO in read and selectCorinna Vinschen2020-03-224-198/+84
| | | | | | | | Get rid of WaitCommEvent and using overlapped_armed to share the same overlapped operation between read and select. Rather, make sure to cancel the overlapped IO before leaving any of these functions. Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
* Cygwin: serial: read: revamp raw_read, change vmin_ and vtime_ to cc_tCorinna Vinschen2020-03-222-94/+117
| | | | | | | | | | | | | | | | | | | | | | | - Datatypes were incorrect, especially vmin_ and vtime_. Change them to cc_t, as in user space. - Error checking had a gap or two. Debug output used the wrong formatting. - Don't use ev member for ClearCommError and WaitCommEvent. Both returned values are different (error value vs. event code). The values are not used elsewhere so it doesn't make sense to store them in the object. Therefore, drop ev member. - Some variable names were not very helpful. Especially using n as lpNumberOfBytesTransferred from GetOverlappedResult and then actually printing it as if it makes sense was quite puzzeling. - Rework the loop and the definition of minchars so that it still makes sense when looping. Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
* Cygwin: serial: select: simplify peek_serialCorinna Vinschen2020-03-221-24/+19
| | | | | | | | | | | | | | | | | | | | | | | | | - Don't use ev member for ClearCommError and WaitCommEvent. Both returned values are different (error value vs. event code). The values are not used elsewhere so it doesn't make sense to store them in the object. - Drop local variable ready which is used inconsequentially. - Since WFSO already waits 10 ms, don't wait again if no char is in the inbound queue. - Avoid else if chains. - Only print one line of debug output on error. - Drop overlapped_armed < 0 check. This value is only set in fhandler_serial::raw_read if VTIME > 0, and even then it's only set to be immediately reset to 0 before calling ReadFile. So overlapped_armed is never actually < 0 when calling select. - Fix a screwed up statement order. Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
* Cygwin: Use a separate Start Menu folder for WoW64 installsJon Turney2020-03-212-7/+10
| | | | | | | | | This aligns the shortcuts to documentation with the setup changes in https://sourceware.org/pipermail/cygwin-apps/2020-March/039873.html v2: Create/remove the Start Menu directory as needed/possible Correctly use that directory when making shortcuts
* Fix hypotf missing mask in hi+lo decompositionFabian Schriever2020-03-191-2/+2
| | | | | | | | | | | Add the missing mask for the decomposition of hi+lo which caused some errors of 1-2 ULP. This change is taken over from FreeBSD: https://github.com/freebsd/freebsd/commit/95436ce20dab5a34ba46373410b96411b1734578 Additionally I've removed some variable assignments which were never read before being overwritten again in the next 2 lines.
* Fix modf/f for NaN inputFabian Schriever2020-03-192-0/+2
| | | | | For NaN input the modf/f procedures should return NaN instead of zero with the sign of the input.
* Fix for k_tan.c specific inputsFabian Schriever2020-03-181-8/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fix for k_tan.c is a copy from fdlibm version 5.3 (see also http://www.netlib.org/fdlibm/readme), adjusted to use the macros available in newlib (SET_LOW_WORD). This fix reduces the ULP error of the value shown in the fdlibm readme (tan(1.7765241907548024E+269)) to 0.45 (thereby reducing the error by 1). This issue only happens for large numbers that get reduced by the range reduction to a value smaller in magnitude than 2^-28, that is also reduced an uneven number of times. This seems rather unlikely given that one ULP is (much) larger than 2^-28 for the values that may cause an issue. Although given the sheer number of values a double can represent, it is still possible that there are more affected values, finding them however will be quite hard, if not impossible. We also took a look at how another library (libm in FreeBSD) handles the issue: In FreeBSD the complete if branch which checks for values smaller than 2^-28 (or rather 2^-27, another change done by FreeBSD) is moved out of the kernel function and into the external function. This means that the value that gets checked for this condition is the unreduced value. Therefore the input value which caused a problem in the fdlibm/newlib kernel tan will run through the full polynomial, including the careful calculation of -1/(x+r). So the difference is really whether r or y is used. r = y + p with p being the result of the polynomial with 1/3*x^3 being the largest (and magnitude defining) value. With x being <2^-27 we therefore know that p is smaller than y (y has to be at least the size of the value of x last mantissa bit divided by 2, which is at least x*2^-51 for doubles) by enough to warrant saying that r ~ y. So we can conclude that the general implementation of this special case is the same, FreeBSD simply has a different philosophy on when to handle especially small numbers.
* Cygwin: serial: wait for CancelIo completionCorinna Vinschen2020-03-161-1/+1
| | | | | | | | Per https://devblogs.microsoft.com/oldnewthing/20110202-00/?p=11613 GetOverlappedResult must be called blocking, waiting for the overlapped operation to complete. Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
* RTEMS: Include missing header and fix stubSebastian Huber2020-03-131-1/+2
| | | | Signed-off-by: Sebastian Huber <sebastian.huber@embedded-brains.de>
* Cygwin: pty: Add FreeConsole to destructor of pty slave.Takashi Yano via Cygwin-patches2020-03-131-2/+9
| | | | | | | - When pseudo console is closed, all the processes attched to the pseudo console are terminated. This causes the problem reported in https://sourceware.org/pipermail/cygwin/2020-March/244046.html. This patch fixes the issue.
* Cygwin: serial: try fix o_nonblockCorinna Vinschen2020-03-121-0/+10
|
* Cygwin: belatedly add Hans-Bernhard to CONTRIBUTORS fileCorinna Vinschen2020-03-111-0/+1
| | | | Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
* Cygwin: fix formatting: drop trailing whitespaceCorinna Vinschen2020-03-1199-117/+117
| | | | Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
* Cygwin: fix formatting: collapse whitespace-only linesCorinna Vinschen2020-03-1122-26/+26
| | | | Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
* Cygwin: fix formatting: drop spaces leading tabsCorinna Vinschen2020-03-1147-137/+137
| | | | Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
* Cygwin: fix formatting: replace TAB char with \t in string constantCorinna Vinschen2020-03-111-1/+1
| | | | Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
* Fix truncf for sNaN inputFabian Schriever2020-03-111-1/+1
| | | | | | | | | | Make line 47 in sf_trunc.c reachable. While converting the double precision function trunc to the single precision version truncf an error was introduced into the special case. This special case is meant to catch both NaNs and infinities, however qNaNs and infinities work just fine with the simple return of x (line 51). The only error occurs for sNaNs where the same sNaN is returned and no invalid exception is raised.
* i386/fenv.c: Include fenv.c implementation shared with x86_64, not stubJoel Sherrill2020-03-101-1/+1
|
* Fix error in fdim/f for infinitiesFabian Schriever2020-03-102-8/+2
| | | | | | | | | | | The comparison c == FP_INFINITE causes the function to return +inf as it expects x = +inf to always be larger than y. This shortcut causes several issues as it also returns +inf for the following cases: - fdim(+inf, +inf), expected (as per C99): +0.0 - fdim(-inf, any non NaN), expected: +0.0 I don't see a reason to keep the comparison as all the infinity cases return the correct result using just the ternary operation.
* Fix error in exp in magnitude [2e-32,2e-28]Fabian Schriever2020-03-092-2/+2
| | | | | | | | | | | | | | | | | | | | While testing the exp function we noticed some errors at the specified magnitude. Within this range the exp function returns the input value +1 as an output. We chose to run a test of 1m exponentially spaced values in the ranges [-2^-27,-2^-32] and [2^-32,2^-27] which showed 7603 and 3912 results with an error of >=0.5 ULP (compared with MPFR in 128 bit) with the highest being 0.56 ULP and 0.53 ULP. It's easy to fix by changing the magnitude at which the input value +1 is returned from <2^-28 to <2^-32 and using the polynomial instead. This reduces the number of results with an error of >=0.5 ULP to 485 and 479 in above tests, all of which are exactly 0.5 ULP. As we were already checking on exp we also took a look at expf. For expf the magnitude where the input value +1 is returned can be increased from <2^-28 to <2^-23 without accuracy loss for a slight performance improvement. To ensure this was the correct value we tested all values in the ranges [-2^-17,-2^-28] and [2^-28,2^-17] (~92.3m values each).
* Cygwin: console: Fix behaviour of "ESC 8" after reset.Takashi Yano2020-03-091-0/+7
| | | | | - This patch matches the behaviour of "ESC 8" (DECRC) to the real xterm after full reset (RIS), soft reset (DECSTR) and "CSI 3 J".
* Do not bother passing optional argument to WriteConsoleA.Hans-Bernhard Broeker2020-03-091-28/+23
| | | | | | | | | | | Passing a pointer to a local variable to WriteConsoleA is not actually needed if we're not going to do anything with what WriteConsoleA would put in there. For the wpbuf class the pointer argument was made optional, so it can be just left out; other call places now pass a NULL pointer instead. The local variables `wn' and `n' are no unused, so they go away.
* Collect handling of wpixput and wpbuf into a helper class.Hans-Bernhard Broeker2020-03-091-65/+76
| | | | | | | Replace direct access to a pair of co-dependent variables by calls to methods of a class that encapsulates their relation. Also replace C #define by C++ class constant.
* Fix error in float trig. function range reductionFabian Schriever2020-03-031-1/+1
| | | | | | | | | | | | | | | | | | The single-precision trigonometric functions show rather high errors in specific ranges starting at about 30000 radians. For example the sinf procedure produces an error of 7626.55 ULP with the input 5.195880078125e+04 (0x474AF6CD) (compared with MPFR in 128bit precision). For the test we used 100k values evenly spaced in the range of [30k, 70k]. The issues are periodic at higher ranges. This error was introduced when the double precision range reduction was first converted to float. The shift by 8 bits always returns 0 as iq is never higher than 255. The fix reduces the error of the example above to 0.45 ULP, highest error within the test set fell to 1.31 ULP, which is not perfect, but still a significant improvement. Testing other previously erroneous ranges no longer show particularly large accuracy errors.
* Cygwin: console: convert wpbuf_put to inline functionCorinna Vinschen2020-03-021-4/+7
| | | | | | fix potential buffer overrun while at it Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
* Cygwin: console: Add a workaround for "ESC 7" and "ESC 8".Takashi Yano2020-03-022-13/+41
| | | | | | | | | | | | - In xterm compatible mode, "ESC 7" and "ESC 8" do not work properly in the senario: 1) Execute /bin/ls /bin to fill screen. 2) Sned CSI?1049h to alternate screen. 3) Reduce window size. 4) Send CSI?1049l to resume screen. 5) Send "ESC 7" and "ESC 8". After sending "ESC 8", the cursor goes to incorrect position. This patch adds a workaround for this issue.
* Cygwin: console: Prevent buffer overrun.Takashi Yano2020-03-021-10/+8
| | | | | - This patch prevent potential buffer overrun in the code handling escape sequences.
* Cygwin: console: Fix setting/unsetting xterm mode for input.Takashi Yano2020-03-021-2/+3
| | | | | | | | | | | | | | - This patch fixes the issue that xterm compatible mode for input is not correctly set/unset in some situation such as: 1) cat is stopped by ctrl-c. 2) The window size is changed in less. In case 1), request_xterm_mode_input(true) is called in read(), however, cat is stopped without request_xterm_mode_input(false). In case 2), less uses longjmp in signal handler, therefore, corresponding request_xterm_mode_input(false) is not called if the SIGWINCH signal is sent within read(). With this patch, InterlockedExchange() is used instead of InterlockedIncrement/ Decrement().
* Cygwin: console: Revise the code to fix tab position.Takashi Yano2020-03-021-12/+3
| | | | | - This patch fixes the issue that the cursor position is broken if window size is changed while executing vim, less etc.
* Cygwin: ioctl: TIOCINQ: always return number of chars in the inbound queueCorinna Vinschen2020-03-022-8/+4
| | | | | | | | | | | | | So far ioctl(TIOCINQ) could end up returning -1 with errno set to EINVAL if a non-zero device error mask has been returned by ClearCommError. This doesn't reflect Linux behaviour, which always returns the number of chars in the inbound queue, independent of any I/O error condition. EINVAL was a pretty weird error code to use in this scenario, too. Fix this by dropping all checking for device errors in the TIOCINQ case. Just return the number of chars in the inbound queue. Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
* Fix error in powf for (-1.0, NaN) inputFabian Schriever2020-03-021-1/+1
| | | | | Prevent confusion between -1.0 and 1.0 in powf. The corresponding similar error was previously fixed for pow (see commit bb25dd1b)
* arm: Finish moving newlib to unified syntax for Thumb1Richard Earnshaw2020-03-022-7/+19
| | | | | | Most code in newlib already uses unified syntax, but just a couple of laggards remain. This patch removes these and means the the entire code base has now been converted.
* Cygwin: console: Adjust the detailed behaviour of ESC sequences.Takashi Yano2020-02-282-7/+45
| | | | | | - This patch makes some detailed behaviour of ESC sequences such as "CSI Ps L" (IL), "CSI Ps M" (DL) and "ESC M" (RI) in xterm mode match with real xterm.
* Cygwin: AF_UNIX: rework fixup_after_execCorinna Vinschen2020-02-284-10/+16
| | | | | | | | | | | | | | | | | fhandler_socket_unix::fixup_after_exec incorrectly calls fhandler_socket_unix::fixup_after_fork with a NULL parent process handle. Not only that calling DuplicateHandle with a NULL parent handle fails, but it's utterly wrong trying to duplicate the handles at all here. Rather just set some important values to NULL and reopen the shared memory region. Create a fixup_helper method to call common code from fixup_after_fork and fixup_after_exec. Add comments to other invocations of fixup_after_fork with NULL handle to mark them as correct this way. Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
* Cygwin: 32 bit: remove old code to 16 bit align stackCorinna Vinschen2020-02-282-21/+6
| | | | | | | | | | | | | | | | | Aligning the stack pointer using an asm statement isn't any longer supported. gcc-9.2.0 generates the following warning: init.cc:33:46: error: listing the stack pointer register '%esp' in a clobber list is deprecated [-Werror=deprecated] [...] init.cc:33:46: note: the value of the stack pointer after an 'asm' statement must be the same as it was before the statement Replace the asm expression with the gcc function attribute `force_align_arg_pointer'. This aligns the stack exactly as required. Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
* Cygwin: AF_UNIX: use Nt functions within Nt functionsCorinna Vinschen2020-02-281-3/+3
| | | | | | Functionaly equivalent, but makes for cleaner code Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
* Cygwin: AF_UNIX: fix creating shared mem region in dupCorinna Vinschen2020-02-281-6/+6
| | | | | | | | | reopen_shmem is accidentally called on the parent fhandler rather than the child fhandler, and it's called too early. Make sure to call it on the child and only after its shmem_handle is valid. Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
* Cygwin: Update dumper for bfd API changesJon Turney2020-02-272-8/+26
| | | | | | | | | Update dumper for bfd API changes in binutils 2.34 libbfd doesn't guarantee API stability, so we've just been lucky this hasn't broken more often. See binutils commit fd361982.
* Cygwin: console: Add emulation of CSI3J on Win10 1809.Takashi Yano2020-02-261-2/+17
| | | | | - This patch add emulation of CSI3J, which is broken in Win10 1809, rather than ignoring it as before.
* Cygwin: console: Add support for REP escape sequence to xterm mode.Takashi Yano2020-02-263-0/+45
| | | | | | | | | | - In Win10 upto 1809, xterm compatible mode does not have REP escape sequence which terminfo declares. This patch adds support for "CSI Ps b" (REP). With this patch, bvi (binary editor) works normally in Win10 1809. Also, xterm compatible mode does not have "CSI Pm `" (HPA), "CSI Pm a" (HPR) and "CSI Ps e" (VPR). However, they do not appear to be declared by terminfo. Therefore, these have been pending.
* Cygwin: console: Unify workaround code for CSI3J and CSI?1049h/l.Takashi Yano2020-02-261-21/+22
| | | | | - This patch unifies workaround code for CSI3J and CSI?1049h/l into the code handling other escape sequences in xterm mode.
* Cygwin: console: Add workaround for broken IL/DL in xterm mode.Takashi Yano2020-02-263-2/+166
| | | | | | | | | - Cygwin console with xterm compatible mode causes problem reported in https://www.cygwin.com/ml/cygwin-patches/2020-q1/msg00212.html if background/foreground colors are set to gray/black respectively in Win10 1903/1909. This is caused by "CSI Ps L" (IL), "CSI Ps M" (DL) and "ESC M" (RI) control sequences which are broken. This patch adds a workaround for the issue.
* Cygwin: ps: fix compiler warning in ttynamCorinna Vinschen2020-02-261-9/+10
| | | | | | | | | | | | | | | The helper function ttynam creates a tty name by using sprintf wrongly on a pretty short buffer. The foramt string only specifies a minimum field length, not a maximum field length, so gcc-9.2.0 complains: ps.cc:101:23: warning: 'sprintf' may write a terminating nul past the end of the destination [-Wformat-overflow=] Fix this thoroughly by specifying a maximum field width as well as by using snprintf with a fixed buffer length. Also, drop using a static buffer in favor of using a buffer in the caller. Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
* Cygwin: cygserver: drop useless packed attributeCorinna Vinschen2020-02-261-9/+3
| | | | | | | | | | | | | ...from structs used for data exchange between clients and cygserver. All of the structs have the same size and member offsets, packed or unpacked. Keeping the packed attribute results in ominous warnings from gcc-9.2.0: cygserver.cc:259:10: warning: taking address of packed member of 'client_request_attach_tty::request_attach_tty' may result in an unaligned pointer value [-Waddress-of-packed-member] Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
* Cygwin: Makefile.in: add -fno-builtin-execve CFLAG when building exec.oCorinna Vinschen2020-02-261-0/+2
| | | | | | | | | | | | | | | | gcc-9.2.0 has an execve builtin which uses the nothrow attribute. This results in an error when aliasing execve to _execve for newlib: exec.cc:88:23: error: 'int _execve(const char*, char* const*, char* const*)' specifies less restrictive attribute than its target 'int execve(const char*, char* const*, char* const*)': 'nothrow' [-Werror=missing-attributes] 88 | EXPORT_ALIAS (execve, _execve) /* For newlib */ Add the -fno-builtin-execve CFLAGS when building exec.o to override the gcc builtin. Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
* Cygwin: posix timers: fix uninitialized variableCorinna Vinschen2020-02-261-1/+1
| | | | | | | | | | | | | | The variable returning the overrun count from the tracker object after disarming the overrun counter was not correctly initialized. For some reason this has only been noticed by gcc-9.2.0, not by the formerly used gcc-7.4.0. This problem should not have had any runtime impact. The method timer_tracker::disarm_overrun_event is supposed to be called in lock-step with timer_tracker::arm_overrun_event, which in turn results in the variable getting a valid value. Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
* cpuinfo:power management: add proc_feedback, acc_powerBrian Inglis2020-02-261-2/+2
| | | | | | | | | | | linux 4.6 x86/cpu: Add advanced power management bits Bit 11 of CPUID 8000_0007 edx is processor feedback interface. Bit 12 of CPUID 8000_0007 edx is accumulated power. Print proper names in /proc/cpuinfo [missed enabling this 2016 change during previous major cpuinfo update as no power related changes were made to the Linux files since then]
* x86_64/i386 fenv: Replace symlink with include fenv_stub.cJoel Sherrill2020-02-2523-23/+161
| | | | | | | | | | | | Having symlinks for these files led to an issue reported to the RTEMS Project that showed up using some tar for native Windows to unpack the newlib sources. It creates symlinks in the tar file as copies of the files the symlinks point to. If the links appear in the tar file before the source exists, it cannot copy the file. The solution in this patch is to convert the files that are symbolic links into simple files which include the file they were linked to. This should be more portable and avoids the symbolinc link problem.
generated by cgit v1.2.3 (git 2.25.1) at 2025-07-16 17:22:50 +0000