summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* Cygwin: utils: refresh tzmapCorinna Vinschen2020-08-072-58/+91
| | | | | | | | - update path to Unicode windowsZones.xml file - drop Windows XP considerations - regenerate tzmap.h Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
* libm: Control errno support with _IEEE_LIBM configuration parameterKeith Packard via Newlib2020-08-056-73/+22
| | | | | | | | | | | | | | | | This removes the run-time configuration of errno support present in portions of the math library and unifies all of the compile-time errno configuration under a single parameter so that the whole library is consistent. The run-time support provided by _LIB_VERSION is no longer present in the public API, although it is still used internally to disable errno setting in some functions. Now that it is a constant, the compiler should remove that code when errno is not supported. This removes s_lib_ver.c as _LIB_VERSION is no longer variable. Signed-off-by: Keith Packard <keithp@keithp.com>
* libm/math: Don't modify __ieee754_pow return values in powKeith Packard via Newlib2020-08-052-26/+2
| | | | | | | | The __ieee754 functions already return the right value in exception cases, so don't modify those. Setting the library to _POSIX_/_IEEE_ mode now only affects whether errno is modified. Signed-off-by: Keith Packard <keithp@keithp.com>
* libm/math: Set errno to ERANGE for pow(0, -y)Keith Packard via Newlib2020-08-052-4/+2
| | | | | | | | | POSIX says that the errno for pow(0, -y) should be ERANGE instead of EDOM. https://pubs.opengroup.org/onlinepubs/9699919799/functions/pow.html Signed-off-by: Keith Packard <keithp@keithp.com>
* libm/math: Make yx functions set errno=ERANGE for x=0Keith Packard via Newlib2020-08-056-42/+52
| | | | | | | | | | The y0, y1 and yn functions need separate conditions when x is zero as that returns ERANGE instead of EDOM. Also stop adjusting the return value from the __ieee754_y* functions as that is already correct and we were just breaking it. Signed-off-by: Keith Packard <keithp@keithp.com>
* libm/math: set errno to ERANGE at gamma polesKeith Packard via Newlib2020-08-054-39/+16
| | | | | | | For POSIX, gamma(i) (i non-positive integer) should set errno to ERANGE instead of EDOM. Signed-off-by: Keith Packard <keithp@keithp.com>
* Cygwin: Add 'fallthrough' pseudo keyword for switch/case useCorinna Vinschen2020-08-0533-63/+67
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch has been inspired by the Linux kernel patch 294f69e662d1 compiler_attributes.h: Add 'fallthrough' pseudo keyword for switch/case use written by Joe Perches <joe AT perches DOT com> based on an idea from Dan Carpenter <dan DOT carpenter AT oracle DOT com>. The following text is from the original log message: Reserve the pseudo keyword 'fallthrough' for the ability to convert the various case block /* fallthrough */ style comments to appear to be an actual reserved word with the same gcc case block missing fallthrough warning capability. All switch/case blocks now should end in one of: break; fallthrough; goto <label>; return [expression]; continue; In C mode, GCC supports the __fallthrough__ attribute since 7.1, the same time the warning and the comment parsing were introduced. Cygwin-only: add an explicit -Wimplicit-fallthrough=5 to the build flags.
* Cygwin: Fix missing breaks in switch statementCorinna Vinschen2020-08-052-0/+10
| | | | | | | Two switch statements in sysconf() and fhandler_fifo::take_ownership were missing breaks. Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
* libm: Set math_errhandling to match library and hardware [v2]Keith Packard via Newlib2020-08-042-1/+22
| | | | | | | | | | | | | | | | math_errhandling is specified to contain two bits of information: 1. MATH_ERRNO -- Set when the library sets errno 2. MATH_ERREXCEPT -- Set when math operations report exceptions MATH_ERRNO should match whether the original math code is compiled in _IEEE_LIBM mode and the new math code has WANT_ERRNO == 1. MATH_ERREXCEPT should match whether the underlying hardware has exception support. This patch adds configurations of this value for RISC-V, ARM, Aarch64, x86 and x86_64 when using HW float. Signed-off-by: Keith Packard <keithp@keithp.com>
* libm/common: Set WANT_ERRNO based on _IEEE_LIBM valueKeith Packard via Newlib2020-08-041-1/+3
| | | | | | | | _IEEE_LIBM is the configuration value which controls whether the original libm functions modify errno. Use that in the new math code as well so that the resulting library is internally consistent. Signed-off-by: Keith Packard <keithp@keithp.com>
* Cygwin: FIFO: add a third pass to raw_readKen Brown2020-08-041-6/+60
| | | | | | | | | | | | | | | | | Currently raw_read makes two passes through the list of clients. On the first pass it tries to read from the client from which it last read successfully. On the second pass it tries to read from all connected clients. Add a new pass in between these two, in which raw_read tries to read from all clients that are in the fc_input_avail case. This should be more efficient in case select was previously called and detected input available. Slightly tweak the first pass. If a client is marked as having the last successful read but reading from it now finds no input, don't unmark it unless we successfully read from a different client on one of the later passes.
* Cygwin: FIFO: fix indentationKen Brown2020-08-041-48/+48
|
* Cygwin: FIFO: synchronize the fifo_reader and fifosel threadsKen Brown2020-08-043-9/+60
| | | | | | | | | | | | | | | | | | | | | | The fifo_reader thread function and the function select.cc:peek_fifo() can both change the state of a fifo_client_handler. These changes are made under fifo_client_lock, so there is no race, but the changes can still be incompatible. Add code to make sure that only one of these functions can change the state from its initial fc_listening state. Whichever function does this calls the fhandler_fifo::record_connection method, which is now public so that peek_fifo can call it. Slightly modify that method to make it suitable for being called by peek_fifo. Make a few other small changes to the fifo_reader thread function to change how it deals with the STATUS_PIPE_CLOSING value that can (rarely) be returned by NtFsControlFile. Add commentary to fhandler_fifo.cc to explain fifo_client connect states and where they can be changed.
* Cygwin: FIFO: don't read from pipes that are closingKen Brown2020-08-043-12/+5
| | | | | | | | | Don't try to read from fifo_client_handlers that are in the fc_closing state. Experiments have shown that this always yields STATUS_PIPE_BROKEN, so it just wastes a Windows system call. Re-order the values in enum fifo_client_connect_state to reflect the new status of fc_closing.
* Cygwin: FIFO: reorganize some fifo_client_handler methodsKen Brown2020-08-043-37/+50
| | | | | | | Rename the existing set_state() to query_and_set_state() to reflect what it really does. (It queries the O/S for the pipe state.) Add a new set_state() method, which is a standard setter, and a corresponding getter get_state().
* Cygwin: FIFO: add a timeout to take_ownershipKen Brown2020-08-043-53/+30
| | | | | | | | | | | | | | fhandler_fifo::take_ownership() is called from select.cc::peek_fifo and fhandler_fifo::raw_read and could potentially block indefinitely if something goes wrong. This is always undesirable in peek_fifo, and it is undesirable in a nonblocking read. Fix this by adding a timeout parameter to take_ownership. Arbitrarily use a 1 ms timeout in peek_fifo and a 10 ms timeout in raw_read. These numbers may have to be tweaked based on experience. Replace the call to cygwait in take_ownership by a call to WFSO. There's no need to allow interruption now that we have a timeout.
* Cygwin: FIFO: fix timing issue with owner changeKen Brown2020-08-041-4/+21
| | | | | | | | | | | | | | | | fhandler_fifo::take_ownership() tacitly assumes that the current owner's fifo_reader_thread will be woken up from WFMO when update_needed_evt is signaled. But it's possible that the the current owner's fifo_reader_thread is at the beginning of its main loop rather than in its WFMO call when that event is signaled. In this case the owner will never see that the event has been signaled, and it will never update the shared fifo_client_handlers. The reader that wants to take ownership will then spin its wheels forever. Fix this by having the current owner call update_shared_handlers at the beginning of its loop, if necessary.
* Cygwin: FIFO: lock fixesKen Brown2020-08-041-6/+17
| | | | | | Add some missing locks and remove one extra unlock. Clarify for some functions whether caller or callee acquires lock, and add appropriate comments.
* fhandler_proc.cc(format_proc_cpuinfo): use _small_sprintf %X for microcodeBrian Inglis2020-08-041-1/+1
| | | | | | | microcode is unsigned long long, printed by _small_sprintf using %x; Cygwin32 used last 4 bytes of microcode for next field MHz, printing 0; use correct _small_sprintf format %X to print microcode, producing correct MHz value under Cygwin32
* fhandler_proc.cc(format_proc_cpuinfo): add SERIALIZE instruction flagBrian Inglis2020-08-041-0/+1
| | | | | | | | | | | | | | | | | | | | CPUID 7:0 EDX[14] serialize added in linux-next 5.8 by Ricardo Neri-Calderon: The Intel architecture defines a set of Serializing Instructions (a detailed definition can be found in Vol.3 Section 8.3 of the Intel "main" manual, SDM). However, these instructions do more than what is required, have side effects and/or may be rather invasive. Furthermore, some of these instructions are only available in kernel mode or may cause VMExits. Thus, software using these instructions only to serialize execution (as defined in the manual) must handle the undesired side effects. As indicated in the name, SERIALIZE is a new Intel architecture Serializing Instruction. Crucially, it does not have any of the mentioned side effects. Also, it does not cause VMExit and can be used in user mode. This new instruction is currently documented in the latest "extensions" manual (ISE). It will appear in the "main" manual in the future. https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/arch/x86/include/asm/cpufeatures.h?id=85b23fbc7d88f8c6e3951721802d7845bc39663d
* libm/math: Use __math_xflow in obsolete math code [v2]Keith Packard2020-08-039-32/+34
| | | | | | | | | | | | | | | | | | C compilers may fold const values at compile time, so expressions which try to elicit underflow/overflow by performing simple arithemetic on suitable values will not generate the required exceptions. Work around this by replacing code which does these arithmetic operations with calls to the existing __math_xflow functions that are designed to do this correctly. Signed-off-by: Keith Packard <keithp@keithp.com> ---- v2: libm/math: Pass sign to __math_xflow instead of muliplying result
* select.h: update FD macros to latest FreeBSD, fix type conversion warningCorinna Vinschen2020-08-031-27/+41
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Compiling #include <sys/select.h> void f(int X) {   fd_set set;   FD_ZERO(&set);   FD_SET(X,&set);   FD_CLR(X+1,&set);   (void)FD_ISSET(X+2,&set); } results in plenty of gcc warnings when compiled with -Wconversion -Wsign-conversion: fds.c:7:2: warning: conversion to ‘long unsigned int’ from ‘int’ may   FD_SET(X,&set);   ^~~~~~ [...] The unsigned NFDBITS macro combined with the signed 1L constant are causing lots of implicit signed/unsigned type conversions. Fix this by updating the FD_* macro code to the latest from FreeBSD and adding an (int) cast to _NFDBITS. As a side-effect, this fixes the visibility of NFDBITS and fds_bits (only if __BSD_VISIBLE). This also eliminates the old, outdated fd_set workaround. Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
* Cygwin: posix_spawn: add Cygwin-specific code fixing process synchronisationCorinna Vinschen2020-08-034-8/+206
| | | | | | | | | | | | | | | | | | | | | | Newlib's posix_spawn has been taken from FreeBSD. The code relies on BSD-specific behaviour of vfork, namely the fact that vfork blocks the parent until the child exits or calls execve as well as the fact that the child shares parent memory in non-COW mode. This behaviour can't be emulated by Cygwin. Cygwin's vfork is equivalent to fork. This is POSIX-compliant, but it's lacking BSD's vfork ingrained synchronization of the parent to wait for the child calling execve, or the chance to just write a variable and the parent will see the result. So this requires a Cygwin-specific solution. The core function of posix_spawn, called do_posix_spawn is now implemented twice, once using the BSD method, and once for Cygwin using Windows synchronization under the hood waiting for the child to call execve and signalling errors upstream. The Windows specifics are hidden inside Cygwin, so newlib only calls internal Cygwin functions. Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
* Cygwin: Speed up dumperJon Turney2020-07-311-9/+4
| | | | | | | | Stop after we've written the dump in response to the initial breakpoint EXCEPTION_DEBUG_EVENT we recieve for attaching to the process. (rather than bogusly sitting there for 20 seconds waiting for more debug events from a stopped process after we've already written the dump).
* Cygwin: Remove synchronization event from dumperJon Turney2020-07-311-12/+0
| | | | | The use of the 'cygwin_error_start_event' for synchronization with dumper was removed from the DLL in commit 8abeff1e (April 2001).
* Cygwin: Add --nokill dumper optionJon Turney2020-07-312-4/+26
| | | | | Add --nokill option to dumper, for compatibility with minidumper, and to assist with testing.
* arm: Fix include to avoid undefined referenceSebastian Huber2020-07-291-1/+1
| | | | | | | ld: libm.a(lib_a-fesetenv.o): in function `fesetenv': newlib/libm/machine/arm/fesetenv.c:38: undefined reference to `vmsr_fpscr' Signed-off-by: Sebastian Huber <sebastian.huber@embedded-brains.de>
* arm: Split fenv.c into multiple filesEshan dhawan2020-07-2919-282/+696
| | | | | | | | | Use the already existing stub files if possible. These files are necessary to override the stub implementation with the machine-specific implementation through the build system. Reviewed-by: Sebastian Huber <sebastian.huber@embedded-brains.de> Signed-off-by: Eshan dhawan <eshandhawan51@gmail.com>
* arm: Fix fenv supportEshan dhawan2020-07-299-772/+127
| | | | | | | | | | | | | | | | | | | The previous fenv support for ARM used the soft-float implementation of FreeBSD. Newlib uses the one from libgcc by default. They are not compatible. Having an GCC incompatible soft-float fenv support in Newlib makes no sense. A long-term solution could be to provide a libgcc compatible soft-float support. This likely requires changes in the GCC configuration. For now, provide a stub implementation for soft-float multilibs similar to RISC-V. Move implementation to one file and delete now unused files. Hide implementation details. Remove function parameter names from header file to avoid name conflicts. Provide VFP support if __SOFTFP__ is not defined like glibc. Reviewed-by: Sebastian Huber <sebastian.huber@embedded-brains.de> Signed-off-by: Eshan dhawan <eshandhawan51@gmail.com>
* Cygwin: Decorate NtQueryVirtualMemory() to fix 32-bit buildJon Turney2020-07-281-1/+1
| | | | | | | Decorate NtQueryVirtualMemory() with NTAPI (for stdcall) to fix 32-bit build. Reported-by: Takashi Yano <takashi.yano@nifty.ne.jp>
* riscv: fix integer wraparound in memcpyPkmX via Newlib2020-07-271-2/+2
| | | | | | | | This patch fixes a bug in RISC-V's memcpy implementation where an integer wraparound occurs when src + size < 8 * sizeof(long), causing the word-sized copy loop to be incorrectly entered. Signed-off-by: Chih-Mao Chen <cmchen@andestech.com>
* fhandler_proc.cc(format_proc_cpuinfo): add flags and TLB sizeBrian Inglis2020-07-241-42/+255
| | | | | | | | | | | | update to Linux-next 5.8 order fields and flags: add amd_dcm, arch_lbr, arch_perfmon, art, cpuid, extd_apicid, ibpb, ibrs, ibrs_enhanced, nonstop_tsc_s3, nopl, rep_good, ring3mwait, ssbd, stibp, tsc_known_freq, tsc_reliable, xtopology flags; add TLB size line; add ftuprint macro for feature test unconditional flag print; add commented out flags requiring CR or MSR access in print order with comment explaining issue; make cpuid leaf numbers consistent 8 hex digits for searching
* Cygwin: mmap: Remove AT_ROUND_TO_PAGE workaroundCorinna Vinschen2020-07-222-106/+43
| | | | | | | | It's working on 32 bit OSes only anyway. It even fails on WOW64. Drop unsupported NtMapViewOfSection flags. Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
* Cygwin: mmap: document recent bugfixKen Brown2020-07-211-0/+3
|
* Cygwin: Use MEMORY_WORKING_SET_EX_INFORMATION in dumperJon Turney2020-07-213-8/+65
| | | | | | | | | | | | | Use the (undocumented) MEMORY_WORKING_SET_EX_INFORMATION in dumper to determine if a MEM_IMAGE region is unsharable, and hence has been modified. After this, we will end up dumping memory regions where: - state is MEM_COMMIT (i.e. is not MEM_RESERVE or MEM_FREE), and -- type is MEM_PRIVATE and protection allows reads (i.e. not a guardpage), or -- type is MEM_IMAGE and attribute is non-sharable (i.e. it was WC, got written to, and is now a RW copy)
* Cygwin: Don't dump non-writable image regionsJon Turney2020-07-211-0/+6
| | | | | | | | | | | | | | | After this, we will end up dumping memory regions where: - state is MEM_COMMIT (i.e. is not MEM_RESERVE or MEM_FREE), and -- type is MEM_PRIVATE and protection allows reads (i.e. not a guardpage), or -- type is MEM_IMAGE and protection allows writes Making this decision based on the current protection isn't 100% correct, because it may have been changed using VirtualProtect(). But we don't know how to determine if a region is shareable. (As a practical matter, anything which gets us the stack (MEM_PRIVATE) and .data/.bss (RW MEM_IMAGE) is going to be enough for 99% of cases)
* Cygwin: Drop excluded regions list from dumperJon Turney2020-07-212-61/+4
| | | | Drop excluded regions, now it's always empty
* Cygwin: Remove reading of PE for section flags from dumperJon Turney2020-07-214-114/+3
|
* Cygwin: Show details of all memory regions in dumper debug outputJon Turney2020-07-211-21/+80
|
* Cygwin: mmap: constify pagesize throughoutCorinna Vinschen2020-07-201-8/+8
| | | | Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
* Cygwin: mmap: fix mapping beyond EOF on 64 bitKen Brown2020-07-201-0/+1
| | | | | | | | | | | | | | | | | | | | | | | Commit 605bdcd410384dda6db66b9b8cd19e863702e1bb enabled mapping beyond EOF in 64 bit environments. But the variable 'orig_len' did not get rounded up to a multiple of 64K. This rounding was done on 32 bit only. Fix this by rounding up orig_len on 64 bit, in the same place where 'len' is rounded up. Rounding up is needed to make sigbus_page_len a multiple of the allocation granularity. In addition, failing to round up could cause orig_len to be smaller than len. Since these are both unsigned values, the statement 'orig_len -= len' could then cause orig_len to be huge, and mmap would fail with errno EFBIG. I observed this failure while debugging the problem reported in https://sourceware.org/pipermail/cygwin/2020-July/245557.html. The failure can be seen by running the test case in that report under gdb or strace.
* Cygwin: pty: Fix a bug on redirecting something to /dev/pty*.Takashi Yano via Cygwin-patches2020-07-201-5/+0
| | | | | | | | | - After commit 0365031ce1347600d854a23f30f1355745a1765c, key input becomes not working by following steps. 1) Start cmd.exe in mintty. 2) Open another mintty. 3) Execute "echo AAA > /dev/pty*" (pty* is the pty opened in 1.) This patch fixes the issue.
* Cygwin: sockets: Rearrange check for connect failureCorinna Vinschen2020-07-201-9/+7
| | | | Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
* Cygwin: FIFO: document recent fixesKen Brown2020-07-161-0/+3
|
* Cygwin: FIFO: update commentaryKen Brown2020-07-161-4/+17
|
* Cygwin: FIFO: clean upKen Brown2020-07-161-6/+4
| | | | | | Remove the fhandler_fifo::get_me method, which is no longer used. Make the methods get_owner, set_owner, owner_lock, and owner_unlock private.
* Cygwin: FIFO: allow take_ownership to be interruptedKen Brown2020-07-163-8/+59
| | | | | | | | Use cygwait in take_ownership to allow interruption while waiting to become owner. Return the cygwait return value or a suitable value to indicate an error. raw_read now checks the return value and acts accordingly.
* Cygwin: fhandler_fifo::take_ownership: don't set event unnecessarilyKen Brown2020-07-161-1/+4
| | | | | | Don't set update_needed_evt if there's currently no owner. This will cause unnecessary churn once I'm the owner and am listening for connections.
* Cygwin: FIFO: add missing lockKen Brown2020-07-161-0/+2
|
* Cygwin: FIFO: make certain errors non-fatalKen Brown2020-07-161-11/+10
| | | | | | | | | If update_my_handlers fails to duplicate one or more handles, just mark the corresponding handlers as being in an error state. But if update_my_handlers is unable to open the process of the previous owner, it's likely that something serious has gone wrong, so we continue to make that a fatal error.