summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Cygwin: FIFO: fix timing issue with owner changeKen Brown2020-08-041-4/+21
| | | | | | | | | | | | | | | | fhandler_fifo::take_ownership() tacitly assumes that the current owner's fifo_reader_thread will be woken up from WFMO when update_needed_evt is signaled. But it's possible that the the current owner's fifo_reader_thread is at the beginning of its main loop rather than in its WFMO call when that event is signaled. In this case the owner will never see that the event has been signaled, and it will never update the shared fifo_client_handlers. The reader that wants to take ownership will then spin its wheels forever. Fix this by having the current owner call update_shared_handlers at the beginning of its loop, if necessary.
* Cygwin: FIFO: lock fixesKen Brown2020-08-041-6/+17
| | | | | | Add some missing locks and remove one extra unlock. Clarify for some functions whether caller or callee acquires lock, and add appropriate comments.
* fhandler_proc.cc(format_proc_cpuinfo): use _small_sprintf %X for microcodeBrian Inglis2020-08-041-1/+1
| | | | | | | microcode is unsigned long long, printed by _small_sprintf using %x; Cygwin32 used last 4 bytes of microcode for next field MHz, printing 0; use correct _small_sprintf format %X to print microcode, producing correct MHz value under Cygwin32
* fhandler_proc.cc(format_proc_cpuinfo): add SERIALIZE instruction flagBrian Inglis2020-08-041-0/+1
| | | | | | | | | | | | | | | | | | | | CPUID 7:0 EDX[14] serialize added in linux-next 5.8 by Ricardo Neri-Calderon: The Intel architecture defines a set of Serializing Instructions (a detailed definition can be found in Vol.3 Section 8.3 of the Intel "main" manual, SDM). However, these instructions do more than what is required, have side effects and/or may be rather invasive. Furthermore, some of these instructions are only available in kernel mode or may cause VMExits. Thus, software using these instructions only to serialize execution (as defined in the manual) must handle the undesired side effects. As indicated in the name, SERIALIZE is a new Intel architecture Serializing Instruction. Crucially, it does not have any of the mentioned side effects. Also, it does not cause VMExit and can be used in user mode. This new instruction is currently documented in the latest "extensions" manual (ISE). It will appear in the "main" manual in the future. https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/arch/x86/include/asm/cpufeatures.h?id=85b23fbc7d88f8c6e3951721802d7845bc39663d
* libm/math: Use __math_xflow in obsolete math code [v2]Keith Packard2020-08-039-32/+34
| | | | | | | | | | | | | | | | | | C compilers may fold const values at compile time, so expressions which try to elicit underflow/overflow by performing simple arithemetic on suitable values will not generate the required exceptions. Work around this by replacing code which does these arithmetic operations with calls to the existing __math_xflow functions that are designed to do this correctly. Signed-off-by: Keith Packard <keithp@keithp.com> ---- v2: libm/math: Pass sign to __math_xflow instead of muliplying result
* select.h: update FD macros to latest FreeBSD, fix type conversion warningCorinna Vinschen2020-08-031-27/+41
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Compiling #include <sys/select.h> void f(int X) {   fd_set set;   FD_ZERO(&set);   FD_SET(X,&set);   FD_CLR(X+1,&set);   (void)FD_ISSET(X+2,&set); } results in plenty of gcc warnings when compiled with -Wconversion -Wsign-conversion: fds.c:7:2: warning: conversion to ‘long unsigned int’ from ‘int’ may   FD_SET(X,&set);   ^~~~~~ [...] The unsigned NFDBITS macro combined with the signed 1L constant are causing lots of implicit signed/unsigned type conversions. Fix this by updating the FD_* macro code to the latest from FreeBSD and adding an (int) cast to _NFDBITS. As a side-effect, this fixes the visibility of NFDBITS and fds_bits (only if __BSD_VISIBLE). This also eliminates the old, outdated fd_set workaround. Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
* Cygwin: posix_spawn: add Cygwin-specific code fixing process synchronisationCorinna Vinschen2020-08-034-8/+206
| | | | | | | | | | | | | | | | | | | | | | Newlib's posix_spawn has been taken from FreeBSD. The code relies on BSD-specific behaviour of vfork, namely the fact that vfork blocks the parent until the child exits or calls execve as well as the fact that the child shares parent memory in non-COW mode. This behaviour can't be emulated by Cygwin. Cygwin's vfork is equivalent to fork. This is POSIX-compliant, but it's lacking BSD's vfork ingrained synchronization of the parent to wait for the child calling execve, or the chance to just write a variable and the parent will see the result. So this requires a Cygwin-specific solution. The core function of posix_spawn, called do_posix_spawn is now implemented twice, once using the BSD method, and once for Cygwin using Windows synchronization under the hood waiting for the child to call execve and signalling errors upstream. The Windows specifics are hidden inside Cygwin, so newlib only calls internal Cygwin functions. Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
* Cygwin: Speed up dumperJon Turney2020-07-311-9/+4
| | | | | | | | Stop after we've written the dump in response to the initial breakpoint EXCEPTION_DEBUG_EVENT we recieve for attaching to the process. (rather than bogusly sitting there for 20 seconds waiting for more debug events from a stopped process after we've already written the dump).
* Cygwin: Remove synchronization event from dumperJon Turney2020-07-311-12/+0
| | | | | The use of the 'cygwin_error_start_event' for synchronization with dumper was removed from the DLL in commit 8abeff1e (April 2001).
* Cygwin: Add --nokill dumper optionJon Turney2020-07-312-4/+26
| | | | | Add --nokill option to dumper, for compatibility with minidumper, and to assist with testing.
* arm: Fix include to avoid undefined referenceSebastian Huber2020-07-291-1/+1
| | | | | | | ld: libm.a(lib_a-fesetenv.o): in function `fesetenv': newlib/libm/machine/arm/fesetenv.c:38: undefined reference to `vmsr_fpscr' Signed-off-by: Sebastian Huber <sebastian.huber@embedded-brains.de>
* arm: Split fenv.c into multiple filesEshan dhawan2020-07-2919-282/+696
| | | | | | | | | Use the already existing stub files if possible. These files are necessary to override the stub implementation with the machine-specific implementation through the build system. Reviewed-by: Sebastian Huber <sebastian.huber@embedded-brains.de> Signed-off-by: Eshan dhawan <eshandhawan51@gmail.com>
* arm: Fix fenv supportEshan dhawan2020-07-299-772/+127
| | | | | | | | | | | | | | | | | | | The previous fenv support for ARM used the soft-float implementation of FreeBSD. Newlib uses the one from libgcc by default. They are not compatible. Having an GCC incompatible soft-float fenv support in Newlib makes no sense. A long-term solution could be to provide a libgcc compatible soft-float support. This likely requires changes in the GCC configuration. For now, provide a stub implementation for soft-float multilibs similar to RISC-V. Move implementation to one file and delete now unused files. Hide implementation details. Remove function parameter names from header file to avoid name conflicts. Provide VFP support if __SOFTFP__ is not defined like glibc. Reviewed-by: Sebastian Huber <sebastian.huber@embedded-brains.de> Signed-off-by: Eshan dhawan <eshandhawan51@gmail.com>
* Cygwin: Decorate NtQueryVirtualMemory() to fix 32-bit buildJon Turney2020-07-281-1/+1
| | | | | | | Decorate NtQueryVirtualMemory() with NTAPI (for stdcall) to fix 32-bit build. Reported-by: Takashi Yano <takashi.yano@nifty.ne.jp>
* riscv: fix integer wraparound in memcpyPkmX via Newlib2020-07-271-2/+2
| | | | | | | | This patch fixes a bug in RISC-V's memcpy implementation where an integer wraparound occurs when src + size < 8 * sizeof(long), causing the word-sized copy loop to be incorrectly entered. Signed-off-by: Chih-Mao Chen <cmchen@andestech.com>
* fhandler_proc.cc(format_proc_cpuinfo): add flags and TLB sizeBrian Inglis2020-07-241-42/+255
| | | | | | | | | | | | update to Linux-next 5.8 order fields and flags: add amd_dcm, arch_lbr, arch_perfmon, art, cpuid, extd_apicid, ibpb, ibrs, ibrs_enhanced, nonstop_tsc_s3, nopl, rep_good, ring3mwait, ssbd, stibp, tsc_known_freq, tsc_reliable, xtopology flags; add TLB size line; add ftuprint macro for feature test unconditional flag print; add commented out flags requiring CR or MSR access in print order with comment explaining issue; make cpuid leaf numbers consistent 8 hex digits for searching
* Cygwin: mmap: Remove AT_ROUND_TO_PAGE workaroundCorinna Vinschen2020-07-222-106/+43
| | | | | | | | It's working on 32 bit OSes only anyway. It even fails on WOW64. Drop unsupported NtMapViewOfSection flags. Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
* Cygwin: mmap: document recent bugfixKen Brown2020-07-211-0/+3
|
* Cygwin: Use MEMORY_WORKING_SET_EX_INFORMATION in dumperJon Turney2020-07-213-8/+65
| | | | | | | | | | | | | Use the (undocumented) MEMORY_WORKING_SET_EX_INFORMATION in dumper to determine if a MEM_IMAGE region is unsharable, and hence has been modified. After this, we will end up dumping memory regions where: - state is MEM_COMMIT (i.e. is not MEM_RESERVE or MEM_FREE), and -- type is MEM_PRIVATE and protection allows reads (i.e. not a guardpage), or -- type is MEM_IMAGE and attribute is non-sharable (i.e. it was WC, got written to, and is now a RW copy)
* Cygwin: Don't dump non-writable image regionsJon Turney2020-07-211-0/+6
| | | | | | | | | | | | | | | After this, we will end up dumping memory regions where: - state is MEM_COMMIT (i.e. is not MEM_RESERVE or MEM_FREE), and -- type is MEM_PRIVATE and protection allows reads (i.e. not a guardpage), or -- type is MEM_IMAGE and protection allows writes Making this decision based on the current protection isn't 100% correct, because it may have been changed using VirtualProtect(). But we don't know how to determine if a region is shareable. (As a practical matter, anything which gets us the stack (MEM_PRIVATE) and .data/.bss (RW MEM_IMAGE) is going to be enough for 99% of cases)
* Cygwin: Drop excluded regions list from dumperJon Turney2020-07-212-61/+4
| | | | Drop excluded regions, now it's always empty
* Cygwin: Remove reading of PE for section flags from dumperJon Turney2020-07-214-114/+3
|
* Cygwin: Show details of all memory regions in dumper debug outputJon Turney2020-07-211-21/+80
|
* Cygwin: mmap: constify pagesize throughoutCorinna Vinschen2020-07-201-8/+8
| | | | Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
* Cygwin: mmap: fix mapping beyond EOF on 64 bitKen Brown2020-07-201-0/+1
| | | | | | | | | | | | | | | | | | | | | | | Commit 605bdcd410384dda6db66b9b8cd19e863702e1bb enabled mapping beyond EOF in 64 bit environments. But the variable 'orig_len' did not get rounded up to a multiple of 64K. This rounding was done on 32 bit only. Fix this by rounding up orig_len on 64 bit, in the same place where 'len' is rounded up. Rounding up is needed to make sigbus_page_len a multiple of the allocation granularity. In addition, failing to round up could cause orig_len to be smaller than len. Since these are both unsigned values, the statement 'orig_len -= len' could then cause orig_len to be huge, and mmap would fail with errno EFBIG. I observed this failure while debugging the problem reported in https://sourceware.org/pipermail/cygwin/2020-July/245557.html. The failure can be seen by running the test case in that report under gdb or strace.
* Cygwin: pty: Fix a bug on redirecting something to /dev/pty*.Takashi Yano via Cygwin-patches2020-07-201-5/+0
| | | | | | | | | - After commit 0365031ce1347600d854a23f30f1355745a1765c, key input becomes not working by following steps. 1) Start cmd.exe in mintty. 2) Open another mintty. 3) Execute "echo AAA > /dev/pty*" (pty* is the pty opened in 1.) This patch fixes the issue.
* Cygwin: sockets: Rearrange check for connect failureCorinna Vinschen2020-07-201-9/+7
| | | | Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
* Cygwin: FIFO: document recent fixesKen Brown2020-07-161-0/+3
|
* Cygwin: FIFO: update commentaryKen Brown2020-07-161-4/+17
|
* Cygwin: FIFO: clean upKen Brown2020-07-161-6/+4
| | | | | | Remove the fhandler_fifo::get_me method, which is no longer used. Make the methods get_owner, set_owner, owner_lock, and owner_unlock private.
* Cygwin: FIFO: allow take_ownership to be interruptedKen Brown2020-07-163-8/+59
| | | | | | | | Use cygwait in take_ownership to allow interruption while waiting to become owner. Return the cygwait return value or a suitable value to indicate an error. raw_read now checks the return value and acts accordingly.
* Cygwin: fhandler_fifo::take_ownership: don't set event unnecessarilyKen Brown2020-07-161-1/+4
| | | | | | Don't set update_needed_evt if there's currently no owner. This will cause unnecessary churn once I'm the owner and am listening for connections.
* Cygwin: FIFO: add missing lockKen Brown2020-07-161-0/+2
|
* Cygwin: FIFO: make certain errors non-fatalKen Brown2020-07-161-11/+10
| | | | | | | | | If update_my_handlers fails to duplicate one or more handles, just mark the corresponding handlers as being in an error state. But if update_my_handlers is unable to open the process of the previous owner, it's likely that something serious has gone wrong, so we continue to make that a fatal error.
* Cygwin: FIFO: fix indentationKen Brown2020-07-161-84/+84
|
* Cygwin: FIFO: improve taking ownership in fifo_reader_threadKen Brown2020-07-161-21/+23
| | | | | | | | | | | | When a reader takes ownership in fifo_reader_thread, it now goes directly to the part of the main loop that listens for a connection. Previously it went back to the beginning of the loop. Also, if the reader has to delay taking ownership because the previous owner has not finished updating the shared fifo_client handlers, it now checks to see if cancel_evt has been set. Previously it might have had to spin its wheels unnecessarily only to eventually find that its thread had been canceled.
* Cygwin: FIFO: reduce I/O interleavingKen Brown2020-07-162-8/+50
| | | | | | | | | | | | | | | | Add a bool member 'last_read' to the fifo_client_handler structure, which is set to true on a successful read. This is used by raw_read as follows. When raw_read is called, it first locates the writer (if any) for which last_read is true. raw_read tries to read from that writer and returns if there is input available. Otherwise, it proceeds to poll all the writers, as before. The effect of this is that if a writer writes some data that is only partially read, the next attempt to read will continue to read from the same writer. This should reduce the interleaving of output from different writers.
* Cygwin: fhandler_fifo::hit_eof: improve reliabilityKen Brown2020-07-163-30/+6
| | | | | Use the writer count introduced in the previous commit to help detect EOF. Drop the maybe_eof method, which is no longer needed.
* Cygwin: FIFO: keep a writer count in shared memoryKen Brown2020-07-162-166/+124
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When a reader opens, it needs to block if there are no writers open (unless is is opened with O_NONBLOCK). This is easy for the first reader to test, since it can just wait for a writer to signal that it is open (via the write_ready event). But when a second reader wants to open, all writers might have closed. To check this, use a new '_nwriters' member of struct fifo_shmem_t, which keeps track of the number of open writers. This should be more reliable than the previous method. Add nwriters_lock to control access to shmem->_nwriters, and remove reader_opening_lock, which is no longer needed. Previously only readers had access to the shared memory, but now writers access it too so that they can increment _nwriters during open/dup/fork/exec and decrement it during close. Add an optional 'only_open' argument to create_shmem for use by writers, which only open the shared memory rather than first trying to create it. Since writers don't need to access the shared memory until they have successfully connected to a pipe instance, they can safely assume that a reader has already created the shared memory. For debugging purposes, change create_shmem to return 1 instead of 0 when a reader successfully opens the shared memory after finding that it had already been created. Remove check_write_ready_evt, write_ready_ok_evt, and check_write_ready(), which are no longer needed. When opening a writer and looping to try to get a connection, recheck read_ready at the top of the loop since the number of readers might have changed. To slightly speed up the process of opening the first reader, take ownership immediately rather than waiting for the fifo_reader_thread to handle it.
* Cygwin: FIFO: fix problems finding new ownerKen Brown2020-07-162-33/+61
| | | | | | | | | | | | | | | | When the owning reader closes and there are still readers open, the owner needs to wait for a new owner to be found before closing its fifo_client handlers. This involves a loop in which dec_nreaders is called at the beginning and inc_nreaders is called at the end. Any other reader that tries to access shmem->_nreaders during this loop will therefore get an inaccurate answer. Fix this by adding an nreaders method and using it instead of dec_nreaders and inc_nreaders. Also add nreaders_lock to control access to the shmem->_nreaders. Make various other changes to improve the reliability of finding a new owner.
* ctype.h: Fix unused variable warningsAschref Ben Thabet2020-07-161-4/+9
| | | | | | | | | | | | | | | | | | | | If __HAVE_LOCALE_INFO__ is not defined, then the locale in the locale-specific ctype functions is ignored. In the previous implementation this resulted in compiler warnings. For example: int main() { locale_t locale; locale = duplocale(uselocale((locale_t)0)); isspace_l('x', locale); return 0; } gcc -Wall main.c main.c: In function 'main': main.c:6:11: warning: variable 'locale' set but not used [-Wunused-but-set-variable] 6 | locale_t locale; | ^~~~~~
* Cygwin: document previous poll/select patchCorinna Vinschen2020-07-161-0/+3
| | | | Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
* Cygwin: make sure failed sockets always signal writabilityMarc Hoersken2020-07-161-0/+6
| | | | | | | | Since FD_CONNECT is only given once, we manually need to set FD_WRITE for connection failed sockets to have consistent behaviour in programs calling poll/select multiple times. Example test to non-listening port: curl -v 127.0.0.1:47
* Cygwin: FAQ 1.6: Update "Who's behind the project?"Brian Inglis2020-07-131-17/+16
| | | | winsup/doc/faq-what.xml: remove Red Hat, Net, Win32 references and clean up
* Cygwin: FAQ 1.5: Clarify "What version is this"Brian Inglis2020-07-131-10/+19
| | | | | | | | | | | | | | Patch to: https://sourceware.org/git/?p=newlib-cygwin.git;f=winsup/doc/faq-what.xml;a=blob as a result of thread: https://cygwin.com/pipermail/cygwin/2020-July/245442.html and comments: https://cygwin.com/pipermail/cygwin-patches/2020q3/010331.html Relate Cygwin DLL to Unix kernel, add required options to command examples, differentiate Unix and Cygwin commands; mention that the cygwin package contains the DLL, replace setup.exe reference by Cygwin Setup program wording.
* Cygwin: Make dumper scan more than first 4GB of VM on x86_64Jon Turney2020-07-121-2/+2
| | | | | It's unclear that we need an end address here at all, or can just rely on VirtualQueryEx() failing when we reach the end of memory regions.
* Cygwin: Add a new win32_pstatus data type for modules on x86_64Jon Turney2020-07-122-4/+16
| | | | | | | Also take a bit more care with sizes in other data types to ensure they are the same on x86 and x86_64. Add some explanatory comments.
* Cygwin: Update ELF target used by dumper on x86_64Jon Turney2020-07-121-2/+8
| | | | | | Like [1], but actually making the effort to be 'usable' and 'tested'. [1] https://cygwin.com/pipermail/cygwin/2019-October/242815.html
* Cygwin: Slightly improve error_start documentationJon Turney2020-07-121-1/+5
|
* testsuite: Fix iconv tests to use new encoding config definesKeith Packard via Newlib2020-07-103-48/+47
| | | | | | | | _ICONV_CONVERTER -> ICONV_FROM_ENCODING. It's not perfect, as the library can support different from/to encodings now, but at least in the default configurations the tests now work. Signed-off-by: Keith Packard <keithp@keithp.com>
generated by cgit v1.2.3 (git 2.25.1) at 2025-07-22 15:39:17 +0000