summaryrefslogtreecommitdiffstats
path: root/winsup
Commit message (Collapse)AuthorAgeFilesLines
* Cygwin: pty: Prevent potential errno overwriting.Takashi Yano2020-02-101-0/+3
| | | | | | | - In push_to_pcon_screenbuffer(), open() and ioctl() are called. Since push_to_pcon_screenbuffer() is called in read() and write(), errno which is set in read() and write() code may be overwritten in open() or ioctl() call. This patch prevent this situation.
* Cygwin: pty: Fix state mismatch caused in mintty.Takashi Yano2020-02-102-2/+16
| | | | | | | - PTY has a bug reported in: https://cygwin.com/ml/cygwin/2020-02/msg00067.html. This is the result of state mismatch between real pseudo console attaching state and state variable. This patch fixes the issue.
* Cygwin: pty: Inherit typeahead data between two input pipes.Takashi Yano2020-02-105-91/+329
| | | | | | | | | | | - PTY has a problem that the key input, which is typed during windows native app is running, disappear when it returns to shell. (Problem 3 in https://cygwin.com/ml/cygwin/2020-02/msg00007.html) This is beacuse pty has two input pipes, one is for cygwin apps and the other one is for native windows apps. The key input during windows native program is running is sent to the second input pipe while cygwin shell reads input from the first input pipe. This patch realize transfering input data between these two pipes.
* Cygwin: pty: Add missing member initialization for struct pipe_reply.Takashi Yano2020-02-101-1/+1
| | | | | - For pseudo console support, struct pipe_reply was changed in the past, however, the initialization was not fixed.
* Cygwin: pty: Remove debug codes and organize related codes.Takashi Yano2020-02-102-81/+23
| | | | | | - Debug codes used in the early stage of pseudo console support are removed. (Regarding ALWAYS_USE_PCON and USE_API_HOOK) Along with this, the codes related to this change are organized.
* Cygwin: pty: Avoid screen distortion on slave read.Takashi Yano2020-02-102-22/+32
| | | | | | - Echo back print is distorted when the cygwin program which calls Win32 console API directly calls slave read(). This patch fixes the issue.
* Cygwin: pty: Define mask_switch_to_pcon_in() in fhandler_tty.cc.Takashi Yano2020-02-102-8/+11
| | | | | - This patch moves the definition of mask_switch_to_pcon() from fhandler.h to fhandler_tty.cc.
* Cygwin: pty: Use pinfo() rather than kill() with signal 0.Takashi Yano2020-02-062-6/+6
| | | | | | | | | - PTY code has a problem that tcsh is terminated if the following command is executed. true; chcp & This seems to be caused by invalid pointer access which occurs when the process exits during the kill() code is execuetd. This patch avoids the issue by not using kill().
* Cygwin: pty: Remove meaningless pointer increment.Takashi Yano2020-02-041-1/+1
| | | | | - Since commit 73742508fcd8e994450582c1b7296c709da66764, a pointer increment in master write code which has no effect was remaining.
* Cygwin: console: Revise color setting codes in legacy console mode.Takashi Yano2020-02-042-21/+28
| | | | | | - With this patch, foreground color and background color are allowed to be set simultaneously by 24 bit color escape sequence such as ESC[38;2;0;0;255;48;2;128;128;0m in legacy console mode.
* Cygwin: fhandler_fifo.cc: add commentaryKen Brown2020-02-011-0/+29
|
* Cygwin: fstat_helper: always use handle in call to get_file_attributeKen Brown2020-01-311-3/+4
| | | | | | | | | When fhandler_base::fstat_helper is called, the handle h returned by get_stat_handle() should be pc.handle() and should be safe to use for getting the file information. Previously, the call to get_file_attribute() for FIFOs set the first argument to NULL instead of h, thereby forcing the file to be opened for fetching the security descriptor in get_file_sd().
* Cygwin: document recent changesKen Brown2020-01-302-0/+8
|
* Cygwin: AF_LOCAL: fix fcntl and dup if O_PATH is setKen Brown2020-01-302-0/+17
| | | | | | | | | | | | Make fhandler_socket_local::dup and fhandler_socket_local::fcntl (a new method) call fhandler_base::dup and fhandler_base::fcntl if O_PATH is set. We're viewing the socket as a disk file here, but there's no need to implement the actions of fhandler_disk_file::dup and fhandler_disk_file::fcntl, which do nothing useful in this case beyond what the fhandler_base methods do. (The extra actions are only useful when I/O is going to be done on the file.)
* Cygwin: AF_LOCAL::fstatvfs: use our handle if O_PATH is setKen Brown2020-01-301-0/+7
| | | | | | | | If O_PATH is set, then the fhandler_socket_local object has a handle that can be used for getting the statvfs information. Use it by calling fhandler_base::fstatvfs_by_handle. Without this change, fhandler_disk_file::fstatfvs would be called on a new fhandler_disk object, which would then have to be opened.
* Cygwin: AF_LOCAL: set appropriate errno on system callsKen Brown2020-01-301-4/+15
| | | | | | | | | | | | | | | | | | | If an AF_LOCAL socket is opened with O_PATH, all socket system calls that take a file descriptor argument fail on the resulting descriptor. Make sure that errno is set as on Linux for those calls that are implemented on Linux. In almost all cases it is ENOTSOCK. There are two exceptions: - sockatatmark(3); errno is EBADF. - bindresvport(3); errno is EAFNOSUPPORT if the second argument sin (of type struct sockaddr_in *) is non-NULL and satisfies sin->sin_family == AF_INET. Finally, there are two BSD socket system calls implemented on Cygwin but not Linux: getpeereid(3) and bindresvport_sa(3). Set errno to ENOTSOCK for these for consistency with the majority of the other calls.
* Cygwin: AF_LOCAL: allow opening with the O_PATH flagKen Brown2020-01-302-0/+22
| | | | | | | | | | | | If that flag is not set, or if an attempt is made to open a different type of socket, the errno is now EOPNOTSUPP instead of ENXIO. This is consistent with POSIX, starting with the 2016 edition. Earlier editions were silent on this issue. Opening is done in a (new) fhandler_socket_local::open method by calling fhandler_base::open_fs. Also add a corresponding fhandler_socket_local::close method.
* Use remove-advertising-clause script to edit BSD licensesKeith Packard2020-01-2918-90/+18
| | | | | | | This edits licenses held by Berkeley and NetBSD, both of which have removed the advertising requirement from their licenses. Signed-off-by: Keith Packard <keithp@keithp.com>
* Cygwin: stat: fix st_mode of fifosCorinna Vinschen2020-01-291-2/+2
| | | | Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
* Cygwin: remove CYGWIN=dos_file_warning optionCorinna Vinschen2020-01-289-49/+14
| | | | | | | This option has been disabled long ago and nobody missed it. Removing drops a bit of unneeded code Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
* Cygwin: FIFO: fstatvfs: use our handle if O_PATH is setKen Brown2020-01-281-0/+8
| | | | | | | | If O_PATH is set, then the fhandler_fifo object has a handle that can be used for getting the statvfs information. Use it by calling fhandler_base::fstatvfs_by_handle. Before this change, fhandler_disk_file::fstatfvs was called on a new fhandler_disk_file object, which would then have to be opened.
* Cygwin: fhandler_disk_file::fstatvfs: refactorKen Brown2020-01-282-6/+17
| | | | | | | | | Define a new method fhandler_base::fstatvfs_by_handle, extracted from fhandler_disk_file::fstatvfs, which gets the statvfs information when a handle is available. This will be used in future commits for special files that have been opened with O_PATH.
* Cygwin: fhandler_base::fstat_fs: accomodate the O_PATH flagKen Brown2020-01-281-1/+1
| | | | | | | | | | | | | Treat a special file opened with O_PATH the same as a regular file, i.e., use its handle to get the stat information. Before this change, fstat_fs opened the file a second time, with the wrong flags and without closing the existing handle. A side effect was to change the openflags of the file, possibly causing further system calls to fail. Currently this change only affects FIFOs, but it will affect AF_LOCAL/AF_UNIX sockets too once they support O_PATH.
* Cygwin: symlink/mknod: fix ACL handlingCorinna Vinschen2020-01-283-55/+57
| | | | | | | | | | | | | | mknod32 actually creates a path_conv, just to call mknod_worker with a win32 path. This doesn't only require to create path_conv twice, it also breaks permissions on filesystems supporting ACLs. Fix this by passing the path_conv created in the caller down to symlink_worker. Also, while at it, simplify the handling of trailing slashes and move it out of symlink_worker. Especially use the new PC_SYM_NOFOLLOW_DIR flag to avoid fiddeling with creating a new path copy without the trailing slash. Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
* Cygwin: path_conv: add PC_SYM_NOFOLLOW_DIR flagCorinna Vinschen2020-01-282-7/+21
| | | | | | | | | | | | | Usually a trailing slash requires to follow an existing symlink, even with PC_SYM_NOFOLLOW. The reason is that "foo/" is equivalent to "foo/." so the symlink is in fact not the last path component, "." is. This is default for almost all scenarios. PC_SYM_NOFOLLOW_DIR now allows the caller to request not to follow the symlink even if a trailing slash is given. This can be used in callers to perform certain functions Linux-compatible. Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
* Cygwin: add short comments to path_conv optionsCorinna Vinschen2020-01-281-12/+13
| | | | Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
* Cygwin: drop __stdcall from close_all_filesCorinna Vinschen2020-01-282-2/+2
| | | | Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
* Cygwin: move chmod_device declaration to winsup.hCorinna Vinschen2020-01-283-2/+1
| | | | Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
* Cygwin: pty: Revise code waiting for forwarding again.Takashi Yano2020-01-284-6/+34
| | | | | | - After commit 6cc299f0e20e4b76f7dbab5ea8c296ffa4859b62, outputs of cygwin programs which call both printf() and WriteConsole() are frequently distorted. This patch fixes the issue.
* Cygwin: console: Share readahead buffer within the same process.Takashi Yano2020-01-285-55/+110
| | | | | | | | | - The cause of the problem reported in https://www.cygwin.com/ml/cygwin/2020-01/msg00220.html is that the chars input before dup() cannot be read from the new file descriptor. This is because the readahead buffer (rabuf) in the console is newly created by dup(), and does not inherit from the parent. This patch fixes the issue.
* Cygwin: FIFO: tweak fcntl and dup when O_PATH is setKen Brown2020-01-241-1/+4
| | | | | fhandler_fifo::fcntl and fhandler_fifo::dup now call the corresponding fhandler_base methods if the FIFO was opened with the O_PATH flag.
* Cygwin: re-implement fhandler_fifo::open with O_PATHKen Brown2020-01-241-8/+2
| | | | | | | | | If the O_PATH flag is set, fhandler_fifo::open now simply calls fhandler_base::open_fs. The previous attempt to handle O_PATH in commit aa55d22c, "Cygwin: honor the O_PATH flag when opening a FIFO", fixed a hang but otherwise didn't do anything useful.
* Cygwin: device_access_denied: return false if O_PATH is setKen Brown2020-01-241-0/+3
| | | | | | | | | | If O_PATH is set in the flags argument of fhandler_base::device_access_denied, return false. No read/write/execute access should be required in this case. Previously, the call to device_access_denied in open(2) would lead to an attempt to open the file with read access even if the O_PATH flag was set.
* Cygwin: Bump DLL version to 3.1.3Corinna Vinschen2020-01-241-1/+1
| | | | Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
* fhandler_proc.cc:format_proc_cpuinfo add rdpru flagBrian Inglis2020-01-231-0/+1
| | | | | | | | rdpru flag is cpuid xfn 80000008 ebx bit 4 added in linux 5.5; see AMD64 Architecture Programmer's Manual Volume 3: General-Purpose and System Instructions https://www.amd.com/system/files/TechDocs/24594.pdf#page=329 and elsewhere in that document
* Cygwin: pty: Remove close() call just before reopening slave.Takashi Yano2020-01-231-1/+0
| | | | | | - After commit da4ee7d60b9ff0bcdc081609a4467adb428d58e6, the issue reported in https://www.cygwin.com/ml/cygwin/2020-01/msg00209.html occurs. This patch fixes the issue.
* add pseudo console fixes to release textnewlib-3.3.0Corinna Vinschen2020-01-221-3/+9
| | | | Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
* Cygwin: pty: Introduce disable_pcon in environment CYGWIN.Takashi Yano2020-01-224-0/+10
| | | | | | - For programs which does not work properly with pseudo console, disable_pcon in environment CYGWIN is introduced. If disable_pcon is set, pseudo console support is disabled.
* Cygwin: pty: Fix reopening slave in push_to_pcon_screenbuffer().Takashi Yano2020-01-221-12/+19
| | | | | | | | - For programs compiled with -mwindows option, reopening slave is needed in push_to_pcon_screenbuffer(), however, it was not at appropriate place. This causes the problem reported in https://www.cygwin.com/ml/cygwin/2020-01/msg00161.html. This patch fixes the issue.
* Cygwin: pty: Revise code waiting for forwarding by master_fwd_thread.Takashi Yano2020-01-213-4/+13
| | | | | | - Though this rarely happens, sometimes the first printing of non- cygwin process does not displayed correctly. To fix this issue, the code for waiting for forwarding by master_fwd_thread is revised.
* Cygwin: document recent changesKen Brown2020-01-202-3/+31
|
* Cygwin: fstatat, fchownat: support the AT_EMPTY_PATH flagKen Brown2020-01-201-6/+41
| | | | | | | | Following Linux, allow the pathname argument to be an empty string if the AT_EMPTY_PATH flag is specified. In this case the dirfd argument can refer to any type of file, not just a directory, and the call operates on that file. In particular, dirfd can refer to a symlink that was opened with O_PATH | O_NOFOLLOW.
* Cygwin: readlinkat: allow pathname to be emptyKen Brown2020-01-171-2/+17
| | | | | | | Following Linux, allow the pathname argument to be an empty string, provided the dirfd argument refers to a symlink opened with O_PATH | O_NOFOLLOW. The readlinkat call then operates on that symlink.
* Cygwin: allow opening a symlink with O_PATH | O_NOFOLLOWKen Brown2020-01-171-1/+1
| | | | | Up to now, opening a symlink with O_NOFOLLOW fails with ELOOP. Following Linux, allow this to succeed if O_PATH is also specified.
* Cygwin: normalize_win32_path: allow drive without trailing backslashKen Brown2020-01-172-1/+5
| | | | | | | | | | | | | | Commit 283cb372, "Cygwin: normalize_win32_path: improve error checking", required a prefix '\\?\' or '\??\' in the source path to be followed by 'UNC\' or 'X:\', where X is a drive letter. That was too restrictive, since it disallowed the paths '\\?\X: and '\??\X:'. This caused problems when a user tried to use the root of a drive as the Cygwin installation root, as reported here: https://cygwin.com/ml/cygwin/2020-01/msg00111.html Modify the requirement so that '\??\X:' and '\\?\X:' are now allowed as source paths, without a trailing backslash.
* Cygwin: pty: Fix state mismatch caused in octave gui.Takashi Yano2020-01-171-0/+9
| | | | | | - In octave gui, sometimes state mismatch between real pty state and state variable occurs. For example, this occurs when 'ls' command is executed in octave gui. This patch fixes the issue.
* Cygwin: pty: Set console code page only if pseudo console is enabled.Takashi Yano2020-01-141-9/+12
| | | | | | - Input UTF-8 chars are garbled in ConEmu with cygwin connector if the environment does not support pseudo console. This patch fixes the issue.
* Cygwin: pty: Disable FreeConsole() on close for non cygwin process.Takashi Yano2020-01-143-4/+16
| | | | | | | | | | | | - After commit e1a0775dc0545b5f9c81b09a327fc110c538b7b4, the problem reported in https://www.cygwin.com/ml/cygwin/2020-01/msg00093.html occurs. For Gnu scren and tmux, calling FreeConsole() on pty close is necessary. However, if FreeConsole() is called, cygwin setup with '-h' option does not work. Therefore, the commit e1a0775dc0545b5f9c81b09a327fc110c538b7b4 delayed closing pty. This is the cause of the problem above. Now, instead of delaying pty close, FreeConsole() is not called if the process is non cygwin processes such as cygwin setup.
* Cygwin: console: Add code to restore console mode on close.Takashi Yano2020-01-141-0/+21
| | | | | | | | - The console with 24bit color support has a problem that console mode is changed if cygwin process is executed in cmd.exe which started in cygwin shell. For example, cursor keys become not working if bash -> cmd -> true are executed in this order. This patch fixes the issue.
* Cygwin: console: Add workaround for broken CSI3J in Win10 1809.Takashi Yano2020-01-143-1/+54
| | | | | | | - In Win10 1809, the cursor position sometimes goes out of screen by clear command in console. This seems to be caused by escape sequence CSI3J (ESC[3J). This happens only for 1809. This patch is a workaround for the issue.