From 79edb254aca9631fd1e83ac4fdfa27acdf564244 Mon Sep 17 00:00:00 2001 From: Corinna Vinschen Date: Sun, 23 Oct 2016 17:16:30 +0200 Subject: passwd: Fix potential buffer overflow Fixes Coverity CID 66956 Signed-off-by: Corinna Vinschen --- winsup/utils/passwd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/winsup/utils/passwd.c b/winsup/utils/passwd.c index 8d9183875..aa8e8cc3a 100644 --- a/winsup/utils/passwd.c +++ b/winsup/utils/passwd.c @@ -592,7 +592,8 @@ main (int argc, char **argv) return SetModals (xarg, narg, iarg, Larg, server); } - strcpy (user, optind >= argc ? getlogin () : argv[optind]); + user[0] = '\0'; + strncat (user, optind >= argc ? getlogin () : argv[optind], UNLEN); /* Changing password for calling user? Use logonserver for user as well. */ if (!server && optind >= argc) -- cgit v1.2.3