From c7432b13faa27c240b8c31bb45d1f2888ef34ffd Mon Sep 17 00:00:00 2001 From: Corinna Vinschen Date: Wed, 16 Dec 2015 12:25:27 +0100 Subject: Fix crash reading invalid SIDs from passwd and group files * grp.cc (pwdgrp::parse_group): Only copy the SID if it's valid. * passwd.cc (pwdgrp::parse_passwd): Ditto. Signed-off-by: Corinna Vinschen --- winsup/cygwin/grp.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'winsup/cygwin/grp.cc') diff --git a/winsup/cygwin/grp.cc b/winsup/cygwin/grp.cc index 501db1a2c..8c3b82198 100644 --- a/winsup/cygwin/grp.cc +++ b/winsup/cygwin/grp.cc @@ -48,8 +48,8 @@ pwdgrp::parse_group () /* Don't generate gr_mem entries. */ grp.g.gr_mem = &null_ptr; cygsid csid; - csid.getfromgr_passwd (&grp.g); - RtlCopySid (SECURITY_MAX_SID_SIZE, grp.sid, csid); + if (csid.getfromgr_passwd (&grp.g)) + RtlCopySid (SECURITY_MAX_SID_SIZE, grp.sid, csid); return true; } -- cgit v1.2.3