summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--ChangeLog1
-rw-r--r--runtime/libgcry_common.c2
-rw-r--r--runtime/stringbuf.c11
-rw-r--r--runtime/stringbuf.h2
4 files changed, 8 insertions, 8 deletions
diff --git a/ChangeLog b/ChangeLog
index 435cae25..cb5ec104 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -4,6 +4,7 @@ Version 7.3.15 [beta] 2013-05-0?
name
Now this triggers an error message and the queue is changed to
linkedList type.
+- bugfix: invalid addressing in string class (recent regression)
---------------------------------------------------------------------------
Version 7.3.14 [beta] 2013-05-06
- bugfix: some man pages were not properly installed
diff --git a/runtime/libgcry_common.c b/runtime/libgcry_common.c
index 63b5e5d5..07a524dc 100644
--- a/runtime/libgcry_common.c
+++ b/runtime/libgcry_common.c
@@ -98,7 +98,7 @@ fprintf(stderr, "pre execve: %s\n", cmd);
*/
/* we should never reach this point, but if we do, we terminate */
-done: return;
+ return;
}
diff --git a/runtime/stringbuf.c b/runtime/stringbuf.c
index 75d2eac4..0d8e7e83 100644
--- a/runtime/stringbuf.c
+++ b/runtime/stringbuf.c
@@ -112,13 +112,12 @@ static rsRetVal rsCStrConstructFromszStrv(cstr_t **ppThis, uchar *fmt, va_list a
DEFiRet;
cstr_t *pThis;
va_list ap2;
- uchar *sz;
int len;
assert(ppThis != NULL);
va_copy(ap2, ap);
- len = vsnprintf(NULL, 0, fmt, ap2);
+ len = vsnprintf(NULL, 0, (char*)fmt, ap2);
va_end(ap2);
if(len < 0)
@@ -133,7 +132,7 @@ static rsRetVal rsCStrConstructFromszStrv(cstr_t **ppThis, uchar *fmt, va_list a
ABORT_FINALIZE(RS_RET_OUT_OF_MEMORY);
}
- vsnprintf(pThis->pBuf, len, fmt, ap);
+ vsnprintf((char*)pThis->pBuf, len, (char*)fmt, ap);
*ppThis = pThis;
finalize_it:
RETiRet;
@@ -142,13 +141,13 @@ finalize_it:
/* construct from a printf-style formated string
*/
-rsRetVal rsCStrConstructFromszStrf(cstr_t **ppThis, uchar *fmt, ...)
+rsRetVal rsCStrConstructFromszStrf(cstr_t **ppThis, char *fmt, ...)
{
DEFiRet;
va_list ap;
va_start(ap, fmt);
- iRet = rsCStrConstructFromszStrv(ppThis, fmt, ap);
+ iRet = rsCStrConstructFromszStrv(ppThis, (uchar*)fmt, ap);
va_end(ap);
RETiRet;
@@ -322,7 +321,7 @@ rsRetVal rsCStrAppendStrf(cstr_t *pThis, uchar *fmt, ...)
CHKiRet(iRet);
iRet = cstrAppendCStr(pThis, pStr);
- rsCStrDestruct(pStr);
+ rsCStrDestruct(&pStr);
finalize_it:
RETiRet;
}
diff --git a/runtime/stringbuf.h b/runtime/stringbuf.h
index b301f4b9..d0502a5b 100644
--- a/runtime/stringbuf.h
+++ b/runtime/stringbuf.h
@@ -58,7 +58,7 @@ rsRetVal cstrConstruct(cstr_t **ppThis);
rsRetVal cstrConstructFromESStr(cstr_t **ppThis, es_str_t *str);
rsRetVal rsCStrConstructFromszStr(cstr_t **ppThis, uchar *sz);
rsRetVal rsCStrConstructFromCStr(cstr_t **ppThis, cstr_t *pFrom);
-rsRetVal rsCStrConstructFromszStrf(cstr_t **ppThis, uchar *fmt, ...);
+rsRetVal rsCStrConstructFromszStrf(cstr_t **ppThis, char *fmt, ...) __attribute__((format(printf,2, 3)));
/**
* Destruct the string buffer object.