summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--ChangeLog4
-rw-r--r--grammar/lexer.l2
-rw-r--r--plugins/imuxsock/imuxsock.c10
3 files changed, 10 insertions, 6 deletions
diff --git a/ChangeLog b/ChangeLog
index 19428d92..d7d2f103 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -597,6 +597,10 @@ expected that interfaces, even new ones, break during the initial
syslog plain tcp input plugin (NOT supporting TLS!)
[ported from v4]
---------------------------------------------------------------------------
+Version 5.10.1 [V5-STABLE], 2012-0?-??
+- bugfix: remove invalid socket option call from imuxsock
+ Thanks to Cristian Ionescu-Idbohrn and Jonny Törnbom
+---------------------------------------------------------------------------
Version 5.10.0 [V5-STABLE], 2012-08-23
NOTE: this is the new rsyslog v5-stable, incorporating all changes from the
diff --git a/grammar/lexer.l b/grammar/lexer.l
index 14e95e81..db875386 100644
--- a/grammar/lexer.l
+++ b/grammar/lexer.l
@@ -191,7 +191,7 @@ int fileno(FILE *stream);
if(!strncasecmp(yytext, "$includeconfig ", 14)) {
yyless(14);
BEGIN INCL;
- } else if(!strncasecmp(yytext, "$ruleset ", 8)) {
+ } else if(!strncasecmp(yytext, "$ruleset ", 9)) {
yylval.s = strdup(yytext);
return LEGACY_RULESET;
} else {
diff --git a/plugins/imuxsock/imuxsock.c b/plugins/imuxsock/imuxsock.c
index 6507fde8..a2c53b52 100644
--- a/plugins/imuxsock/imuxsock.c
+++ b/plugins/imuxsock/imuxsock.c
@@ -484,7 +484,9 @@ static inline rsRetVal
openLogSocket(lstn_t *pLstn)
{
DEFiRet;
+# if HAVE_SCM_CREDENTIALS
int one;
+# endif /* HAVE_SCM_CREDENTIALS */
if(pLstn->sockName[0] == '\0')
return -1;
@@ -525,10 +527,6 @@ openLogSocket(lstn_t *pLstn)
errmsg.LogError(errno, NO_ERRCODE, "set SO_PASSCRED failed on '%s'", pLstn->sockName);
pLstn->bUseCreds = 0;
}
- if(setsockopt(pLstn->fd, SOL_SOCKET, SCM_CREDENTIALS, &one, sizeof(one)) != 0) {
- errmsg.LogError(errno, NO_ERRCODE, "set SCM_CREDENTIALS failed on '%s'", pLstn->sockName);
- pLstn->bUseCreds = 0;
- }
// TODO: move to its own #if
if(setsockopt(pLstn->fd, SOL_SOCKET, SO_TIMESTAMP, &one, sizeof(one)) != 0) {
errmsg.LogError(errno, NO_ERRCODE, "set SO_TIMESTAMP failed on '%s'", pLstn->sockName);
@@ -961,8 +959,10 @@ static rsRetVal readSocket(lstn_t *pLstn)
struct ucred *cred;
struct timeval *ts;
uchar bufRcv[4096+1];
- char aux[128];
uchar *pRcv = NULL; /* receive buffer */
+# if HAVE_SCM_CREDENTIALS
+ char aux[128];
+# endif
assert(pLstn->fd >= 0);