| Commit message (Collapse) | Author | Age | Files | Lines |
|\ |
|
| |
| |
| |
| |
| |
| |
| | |
this could cause loss of messages. The handling was correct if the
connection broke, but not if there was a problem with statement
execution. The most probable case for such a case would be invalid
sql inside the template, and this is now much easier to diagnose.
|
|\|
| |
| |
| |
| |
| | |
Conflicts:
configure.ac
doc/manual.html
|
| |
| |
| |
| |
| |
| | |
bugfix: the default for $DirCreateMode was 0644, and as such wrong.
It has now been changed to 0700. For some background, please see
http://lists.adiscon.net/pipermail/rsyslog/2009-April/001986.html
|
| |
| |
| |
| |
| | |
This one did not surface yet and the issue was actually found due to
a problem in v4 - but better fix it here, too.
|
| |
| |
| |
| |
| | |
... one should at least compile before comitting - sorry, been so
eager to push that out.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
It looks like a race was introduced by not locking the message mutex
in msgDestruct(). In theory, I thought, the decrement should be atomic,
but the whole operation may be reordered. Also it has potential for task
switches. If so, that would lead to a too-early destruction and thus
a potential double free - exactly what we have seen from time to time.
So I think this fix addresses the issue.
I have also removed anything that looks like atomic operations are supported
in this version - they are not. This was very late added, found to be
non-portable and pulled from that release.
|
| |
| |
| |
| |
| |
| | |
On HUP, the root pointers were not properly cleaned up. Thanks to
Michael Biebel, olgoat, and Juha Koho for reporting and analyzing
the bug.
|
|\| |
|
| |
| |
| |
| |
| | |
Thanks to William Tisater for analyzing this bug and providing a patch.
The actual code change is heavily based on William's patch.
|
| |
| |
| |
| | |
Signed-off-by: Rainer Gerhards <rgerhards@adiscon.com>
|
| |
| |
| |
| | |
Signed-off-by: Rainer Gerhards <rgerhards@adiscon.com>
|
| |
| |
| |
| | |
Signed-off-by: Rainer Gerhards <rgerhards@adiscon.com>
|
| |
| |
| |
| |
| |
| |
| | |
- security bugfix: $AllowedSender was not honored, all senders were
permitted instead (see http://www.rsyslog.com/Article322.phtml)
(backport from v3-stable, v3.20.9)
- minor bugfix: dual close() call on tcp session closure
|
| | |
|
|\|
| |
| |
| |
| |
| | |
Conflicts:
syslogd.c
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Thanks to Frederico Nunez for providing the fix. The actual patch
was commited before this one - unfortunately I forgot to set
the author correct when commiting it and then it was pushed to
the online repository. Sorry for this ;)
Signed-off-by: Rainer Gerhards <rgerhards@adiscon.com>
|
| |
| |
| |
| |
| |
| |
| | |
- a big one in syslogd.c, which caused messages not to be
freed when compiled for single-threading mode
- a small one in the file output handler, outchannels, when
a size-reached action was to be executed
|
| |
| |
| |
| |
| |
| | |
if queue size reached light_delay mark, enqueuing
could potentially be blocked for a longer period of time, which
was not the behaviour desired.
|
| |
| |
| |
| |
| |
| | |
because getnameinfo() is not cancel-safe, but was not guarded against
being cancelled. pthread_cancel() is routinely being called during
HUP processing.
|
| | |
|
| |
| |
| |
| | |
thanks to Michael Biebl for suggesting it
|
| |
| |
| |
| | |
Signed-off-by: Rainer Gerhards <rgerhards@adiscon.com>
|
| | |
|
| |
| |
| |
| |
| | |
... as $...OnlyIfPrev... in some parts of the documentation. Thanks to
Lorenzo M. Catucci for reporting this bug.
|
| |
| |
| |
| |
| | |
It did not properly de-init a variable acting as a linked list head.
That resulted in trying to access freed memory blocks after the HUP.
|
| | |
|
| | |
|
|\|
| |
| |
| |
| |
| |
| | |
Conflicts:
ChangeLog
syslogd.c
|
| |
| |
| |
| |
| |
| |
| |
| | |
this caused a very minor issue with re-formatting a RFC3164 date when the
message was invalidly formatted and had a colon immediately after the date.
This was in the code for some years (even v1 had it) and I think it never
had any effect at all in practice. Though, it should be fixed - but definitely
nothing to worry about.
|
| |
| |
| |
| |
| | |
This has now been corrected. Required change to the
internal ParseTIMESTAMP3164() interface.
|
| |
| |
| |
| |
| |
| | |
resulting in strange operations.
Signed-off-by: Rainer Gerhards <rgerhards@adiscon.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
default discard severity was incorrectly set to 4, which lead
to discard-on-queue-full to be enabled by default. That could cause
message loss where non was expected. The default has now been changed
to the correct value of 8, which disables the functionality. This
problem applied both to the main message queue and the action queues.
Thanks to Raoul Bhatia for pointing out this problem.
|
| |
| |
| |
| |
| |
| | |
Queue full is now -2074 and -2025 is unique again.
(did cause no real problem
except for troubleshooting)
|
| |
| |
| |
| | |
Signed-off-by: Rainer Gerhards <rgerhards@adiscon.com>
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
file parser.
Could lead to invalid sizes, constraints etc for e.g. queue files
and any other object whose size was specified
in base-10 entities. Did not apply to binary entities.
Signed-off-by: Rainer Gerhards <rgerhards@adiscon.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
(until the previous time was reached again). There are still some
side-effects when time is rolled back (A time rollback is really a bad
thing to do, ideally the OS should issue pseudo time (like NetWare did)
when the user tries to roll back time).
Signed-off-by: Rainer Gerhards <rgerhards@adiscon.com>
|
| | |
|
| |
| |
| |
| | |
...which fixed the imfile segfault issue.
|
| | |
|
| |
| |
| |
| |
| | |
Thanks to lperr for an excellent bug report that helped detect this
problem.
|
| |
| |
| |
| |
| |
| | |
It could cause system hangs under some circumstances.
The devel (3.21.3 and above) will re-enable it and provide
enhanced configurability to overcome the problems if they occur.
|
| |
| |
| |
| |
| |
| | |
Port can be set via new $ActionOmmysqlServerPort config directive
Note: this was a very minor change and thus deemed appropriate to be
done in the stable release.
|
| |
| |
| |
| |
| |
| |
| |
| | |
Previously was $MainMsgQueueWorkeTimeoutrThreadShutdown, is now
$MainMsgQueueWorkerTimeoutThreadShutdown. Note that the misspelled
directive is not preserved - if the misspelled directive was used
(which I consider highly unlikely), the config file must be changed.
Thanks to lperr for reporting the bug.
|
| | |
|
|\|
| |
| |
| |
| |
| |
| |
| |
| | |
Conflicts:
ChangeLog
doc/manual.html
doc/rsyslog_conf.html
omfwd.c
|
| |
| |
| |
| |
| | |
New syntax @[addr]:port introduced to enable that. Root problem was IPv6
addresses contain colons. (backport from 3.21.3)
|
| |
| |
| |
| | |
Signed-off-by: Rainer Gerhards <rgerhards@adiscon.com>
|
| |
| |
| |
| |
| |
| |
| |
| | |
Update the documentation to use the new, preferred $ModLoad syntax:
- no more MySQL
- name of the in/output plugin without the trailing .so
Signed-off-by: Rainer Gerhards <rgerhards@adiscon.com>
|