| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| |
| |
| | |
Conflicts:
ChangeLog
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This usually lead to a syntax error on startup and rsyslogd not actually
starting up. The problem was the regex, which did not care for double
quote characters to follow in the action part - unfortunately something
that can frequently happen with v6+ format. An example:
:programname, isequal, "as" {action(type="omfile" ...) }
Here, the part
:programname, isequal, "as" {action(type="omfile"
was treated as the property filter, and the rest as action part.
Obviously, this did not work out. Unfortunately, such situations usually
resulted in very hard to understand error messages.
|
| | |
|
|\|
| |
| |
| |
| |
| | |
Conflicts:
ChangeLog
configure.ac
|
| | |
|
| |
| |
| |
| | |
present.
|
| | |
|
| | |
|
| |
| |
| |
| | |
David)
|
| |
| |
| |
| |
| | |
...due to invalid assumption on structure data types.
closes: http://bugzilla.adiscon.com/show_bug.cgi?id=394
|
| |
| |
| |
| |
| | |
...when FromPos was specified in template, but ToPos not.
Thanks to Radu Gheorghe for alerting us of this bug.
|
|\|
| |
| |
| |
| | |
Conflicts:
plugins/omudpspoof/omudpspoof.c
|
| |
| |
| |
| |
| |
| |
| | |
The problem was that incomplete fiter evaluation was done *during the
shutdown phase*. This affected only the LAST batches being processed. No
problem existed during the regular run. Could usually only happen on
very busy systems, which were still busy during shutdown.
|
| |\
| | |
| | |
| | |
| | | |
Conflicts:
plugins/omudpspoof/omudpspoof.c
|
| | |\ |
|
| | | |
| | | |
| | | |
| | | |
| | | | |
it now truncates these message, but ensures they are sent. Note that
7.2.5+ will switch to fragmented UDP messages instead (up to 64K)
|
| | | |
| | | |
| | | |
| | | | |
retains bugfix while increasing performance again
|
| | | | |
|
|/ / /
| | |
| | |
| | |
| | |
| | | |
On Ethernet, they need to be transmitted in multiple fragments. While
it is known that fragmentation can cause issues, it is the best choice
to be made in that case. Also improved debug output.
|
| | | |
|
|\| | |
|
| |\|
| | |
| | |
| | |
| | | |
Conflicts:
ChangeLog
|
| | | |
|
| | | |
|
| | | |
|
|\| |
| | |
| | |
| | |
| | | |
Conflicts:
tools/syslogd.c
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This happened only on very high volume systems, if the same message was
being processed by two different actions. This was a regression caused
by the new config processor, which did no longer properly enable msg
locking in multithreaded cases. The bugfix is actually a refactoring of
the msg locking code - we no longer do unlocked operations, as the use
case for it has mostly gone away. It is potentially possible only at
very low-end systems, and there the small additional overhead of doing
the locking does not really hurt. Instead, the removal of that
capability can actually slightly improve performance in common cases,
as the code path is smaller and requires slightly less memory writes.
That probably outperforms the extra locking overhead (which in the
low-end case always happens in user space, without need for kernel
support as we can always directly aquire the lock - there is no
contention at all).
|
| | |
| | |
| | |
| | | |
Released under ASL 2.0, permission given via email.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The "queue.xxx" parameter set was not supported, and legacy ruleset
config statements did not work (by intention). The fix introduces the
"queue.xxx" parameter set. It has some regression potential, but only
for the new functionality. Note that using that interface it is possible
to specify duplicate queue file names, which will cause trouble. This
will be solved in v7.3, because there is a too-large regression
potential for the v7.2 stable branch.
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
registered
This lead to a "module not found" error message instead of
the to-be-expected "module does not support new style" error message.
That invalid error message could be quite misleading and actually stop
people from addressing the real problem (aka "go nuts" ;))
|
| | | |
|
|\| | |
|
| | |
| | |
| | |
| | | |
which could also mean "never" or "not for a very long time".
|
| | | |
|
|\| | |
|
| |\|
| | |
| | |
| | |
| | | |
Conflicts:
ChangeLog
|
| | | |
|
| | | |
|
|\| | |
|
| |\|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Note: this was not a simple merge, I rather needed to adopt the v5 code to
the new v6 config handling. However, no v6 config format has been added yet
(this is the next step).
Conflicts:
plugins/imklog/imklog.c
plugins/imklog/imklog.h
|
| | |
| | |
| | |
| | |
| | |
| | | |
... actually, they are microseconds. So the fractional part of the
timestamp was not properly formatted.
Thanks to Marius Tomaschwesky for the bug report and the patch idea.
|
| | | |
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Most importantly, the last patch for imfile contained a number
of glitches, which are fixed by this commit (a memory leak under
unusual conditions, partial message loss when rsyslog was
terminated in the interim & mixing file data to the wrong files
when multiple monitors were used [due to static variable]). The
commit is actually a re-write of the patch, based on its core
idea.
Also some other minor cleanup was done.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
File lines that were incomplete (LF missing) *at the time imfile polled
the file* were partially discarded. That part of the line that was read
without the LF was discarded, and the rest of the line was submitted in
the next polling cycle. This is now changed so that the partial content
is saved until the complete line is read. Note that the patch affects
only read mode 0.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
If the property name was followed by a space before the comma, rsyslogd
aborted on startup. Note that no segfault could happen if the initial
startup went well (this was a problem with the config parser).
closes: http://bugzilla.adiscon.com/show_bug.cgi?id=381
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The length for the field name was invalidly computed, resulting in either
truncated field names or including extra random data. If the random data
contained NULs, the rest of the message became unreadable.
closes: http://bugzilla.adiscon.com/show_bug.cgi?id=374
|
| | | |
|