From 60217da3968bcc62048f6afd4c8c77565789c3da Mon Sep 17 00:00:00 2001 From: Rainer Gerhards Date: Wed, 28 Nov 2012 15:12:56 +0100 Subject: bugfix: mmnormalize could abort rsyslog if config parameter was in error --- ChangeLog | 1 + plugins/mmnormalize/mmnormalize.c | 6 +++++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index b395db0f..ebf16c6d 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,6 +1,7 @@ --------------------------------------------------------------------------- Version 7.3.5 [devel] 2012-11-?? - bugfix: mmnormalize build problems +- bugfix: mmnormalize could abort rsyslog if config parameter was in error --------------------------------------------------------------------------- Version 7.3.4 [devel] 2012-11-23 - further (and rather drastically) improved disk queue performance diff --git a/plugins/mmnormalize/mmnormalize.c b/plugins/mmnormalize/mmnormalize.c index 2d42886b..9dbde497 100644 --- a/plugins/mmnormalize/mmnormalize.c +++ b/plugins/mmnormalize/mmnormalize.c @@ -249,15 +249,18 @@ setInstParamDefaults(instanceData *pData) BEGINnewActInst struct cnfparamvals *pvals; int i; + int bDestructPValsOnExit; CODESTARTnewActInst DBGPRINTF("newActInst (mmnormalize)\n"); + bDestructPValsOnExit = 0; pvals = nvlstGetParams(lst, &actpblk, NULL); if(pvals == NULL) { errmsg.LogError(0, RS_RET_MISSING_CNFPARAMS, "mmnormalize: error reading " "config parameters"); ABORT_FINALIZE(RS_RET_MISSING_CNFPARAMS); } + bDestructPValsOnExit = 1; if(Debug) { dbgprintf("action param blk in mmnormalize:\n"); @@ -284,7 +287,8 @@ CODESTARTnewActInst iRet = buildInstance(pData); CODE_STD_FINALIZERnewActInst - cnfparamvalsDestruct(pvals, &actpblk); + if(bDestructPValsOnExit) + cnfparamvalsDestruct(pvals, &actpblk); ENDnewActInst -- cgit v1.2.3