| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* who.tl (attr-warning-macrolet): Do not warn when
fmt and escj are used on attributes. Instead, give
them a useful definition so they do what the
programmer wants: return a string.
* test/simple.tl: Trim it
to just the tags that should warn now. Also
fix a bug that rendered this case invalid:
unquote occurred with no backquote, and this
produced an undefined variable warning on
sym, which was treated by the test case's handler
as a false positive that made it pass.
New test case 45 testing fmt and escj in
attributes.
* README.md: Added to notes on differences between
TL-WHO and CL-WHO.
|
| |
|
|
|
|
|
|
|
| |
* who.tl (with-html-output): Arrange for
tostringp to be called on argument of esc and escq.
* test/simple.tl: New test 44.
* README.tl: mention as a difference from CL-WHO.
|
| |
|
|
|
|
|
|
|
|
|
| |
* CHANGELOG: File removed. Changelogs are not useful;
they can be reconstructed from version control comments.
I will create a RELNOTES file for release notes.
* cl-who.asd: Removed; no ASDF in TXR Lisp.
* test/packages.lisp, test/tests.lisp: Files removed;
the test/simple.tl is self-contained.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The escq macro provides HTML escaping for the apostrophe
and double quote also, whereas esqj is for escaping material
to be put into a Javascript literal.
* packages.tl (tl-who): New symbols escq and escj.
* who.tl (attr-warning-macrolet): Add escq and escq to
list of WHO local macros that are not warned about if
they occur in attributes.
(with-html-output): Add escq and escj.
* test/simple.tl: Test 41 updated to include escq and
escj. New tests 42 and 43.
* README.md: Mention escq and escj.
|
| |
|
|
|
|
| |
* README.mt: Mention that html-encode* is used by esc and
fmt, which leaves quotes alone. Attribute quoting uses
html-escape which escapes quotes too.
|
| |
|
|
|
| |
* who.tl (attr-warning-macrolet): Reduce repeated code by
iterating over a list of symbols.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The with-html-output ("WHO") macro defines some local macrolets.
Those are in scope of the entire thing, but they can only be
meaningfully used in the imperative Lisp forms that are placed
into the HTML tag body. If they are used in an attribute
expression, it's probably a programming error; an output
side effect doesn't belong there. We implement a diagnostic
strategy which produces a warning in this situation.
* who.tl (attr-warning-macrolet): New function, which
wraps macrolet code around the expression passed in.
These macrolets intercept the local macros and generate
a warning. Then they decline to expand, deferring to the
real macros.
(convert-attributes): Wrap the warning macrolets around
the run-time evaluation of the val expression. We don't
do anything for the compile-time evaluation of a constant
attribute expression, because the macro calls we want
to intercept do not appear in a constant expression.
* test/simple.tl: New test 41 validating that warnings
are generated for all the local macros when they are called
from an attr expression.
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
* packages.tl (tl-who): Add noesc-fmt symbol.
* who.tl (with-html-output): Add escaping to fmt,
which is disabled under *cl-who-compat*.
Add noesc-fmt macro that looks like former definition
of fmt.
* test/simple.tl: New test cases 38-40.
* README.md: Mention that TL-WHO provides noesc-fmt.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CL-WHO tries to handle the case when attribute values are
constant NIL and T values, but it bungles it; it applies
the correct behavior only when the constants are literally
these symbols, not when they are constant expressions
which evaluate to these values.
Secondly, CL-WHO neglects to HTML-escape attribute values.
We fix this behavior and introduce a noesc operator to
selectively revert it, as well as a *cl-who-compat* special
to revert the behavior more pervasively, for the daredevils.
* packages.tl (tl-who): New symbols *cl-who-compat* and noesc.
* specials.tl (*cl-who-compat*): New special variable.
* who.tl (convert-attributes): When treating a constant
expression, evaluate it first, then check for nil or t.
Escape interpolated text with html-encode.
Check the original expression for (noesc ...) pattern,
or the presence of *cl-who-compat*. In these cases, don't
generate the escape call.
* test/simple.tl: New tests 28 to 37 providing some coverage
to all these changes.
* README.md: Document.
|
| |
|
|
|
|
|
| |
* README.md: Add a note about Lisp evaluation: Lisp
expressions that give attribute values are interpolated
into HTML; Lisp expressions in tag body are evaled
for side effect only.
|
| |
|
|
|
|
|
| |
* simple.tl: Translate and enable all tests.
* who.tl (process-tag): Fix double nreverse bug
causing attr list to be truncated to one tag.
|
| | |
|
| |
|
|
|
|
| |
Test case 8 had to be adjusted to bind *attribute-quote-char*
using expander-let instead of let, so this is a difference
worth mentioning.
|
| | |
|
| |
|
|
| |
* test/simple.tl: Port tests 7 through 8 and move (exit).
|
| |
|
|
|
|
|
|
|
|
|
| |
* who.tl (convert-attributes): In the run-time case,
we must generate code to print the calculated
string, not just to calculate it.
(convert-tag-to-string-list): Test the original tag
keyword against the *html-empty-tags*, not the
transformed string.
* test/simple.tl: Port and enable tests 1 to 7.
|
| |
|
|
|
|
|
| |
* test/simple: renamed to simple.tl. Just a self-contained
file we can run. The first test has been rewritten to TL.
After that we (exit). The first test is failing; it is
not rendering any attributes.
|
| |
|
|
|
|
| |
* README.md, LICENSE: New files.
* who.tl: Add copyright notice.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is an issue present in the original Common Lisp
implementation. When the (htm ...) inner macros are
being expanded, they are not receiving the *indent*
level.
We address this by adding yet another unreleased feature
to TXR Lisp that will appear in TXR 287: expander-let.
* who.tl (tree-to-template): Here, instead of generating
a ^(let ((*indent* , *indent*)) ...) which does nothing,
we use expander-let. All the expansion of the structured
code to HTML text fragments happens at macro-expansion
time. But macro-expansion time will not execute a binding
form like (let ((*indent* <value>)) ...). It will just
expand it! The (htm ...) subforms get expanded in a
context in which all the functions that expanded the outer
macro have already terminated and undone their own
local binding of *indent*. The expander-let construct
causes the macro expander itself to do the binding. So
it will pick up the indentation where the previous
expansion pass left off.
(with-html-output): The previous fix isn't enough, because
the way the local html macro is defined also wrecks
indentation. htm expands to an invocation of with-html-output
which copies the :indent argument value from the surrouning
with-html-output. If that is 0 or t, it will reset the
indentation to zero. The htm macro should just leave the
indentation alone; not pass that keyword argument so that
the current *indent* value gets propagated.
|
| |
|
|
|
|
| |
This relies on an improvement in TXR Lisp that will
be released in TXR 287: parameter macros like :key being
expanded inside nested macro parameter lists.
|
| |
|
|
|
| |
* Fix keyword bloating in DEFPACKAGE :EXPORT clauses
* Fix keyword bloating in DEFPACKAGE :SHADOW clause
|
| |
|
|
| |
XML tags).
|
| | |
|
| | |
|
| |
|
| |
Can't keep up with them going away and listing new ones.
|
| | |
|
| | |
|
| |
|
|
| |
Reported by @gptix in #21
|
| | |
|
| |
|
|
|
| |
See https://www.w3.org/TR/html-markup/syntax.html#syntax-attr-empty for
spesification.
|
| | |
|
| | |
|
| | |
|
| | |
|
| |\
| |
| | |
Add a type-check for a stream in with-html-output.
|
| |/
|
|
| |
Avoids confusion caused in Issue #14.
|
| | |
|
| | |
|
| |\ |
|
| | |\
| | |
| | | |
Adding missing comma
|
| | |/ |
|
| |/ |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
