From 3a0dd126b7f760858051d24970f5c93f6aed965e Mon Sep 17 00:00:00 2001 From: Kaz Kylheku Date: Mon, 16 Apr 2018 06:36:58 -0700 Subject: Makefile: bugfix: shell quoting issue in macro. * Makefile (SH): The $(1) macro argument is substituted into a shell '...' quote. It may contain single quotes itself, so these have to be mapped to the famous '\'' sequence. Currently, only one SH call has '...' syntax in it: one in the y.tab.c rule which calls sed -e '/yyparse/d'. That works anyway, and the quotes could be removed from it; but let's fix the SH macro. --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index b8cc40fb..108cdcc6 100644 --- a/Makefile +++ b/Makefile @@ -114,7 +114,7 @@ endef define SH $(if $(VERBOSE), \ $(1), \ - $(V)cmd='$(1)' ; \ + $(V)cmd='$(subst ','\'',$(1))' ; \ if ! eval "$$cmd" ; then \ printf "make: failing command:\n%s\n" "$$cmd"; \ exit 1; \ -- cgit v1.2.3