From d8a8c64b0b15bfbe1af29d3905325037135edc00 Mon Sep 17 00:00:00 2001 From: Kaz Kylheku Date: Wed, 14 Jun 2017 22:02:11 -0700 Subject: bugfix: sign-extend broken for bignums. * arith.c (sign_extend): After taking the two's complement which works at the granularity of digits, not the exact number of bits, we must truncate the number to the exact number of bits before negating. Otherwise we end up with an excessively large value. For instance if a bignum like #x80... is sign extended tightly to the upper 1 bit, the resulting value is something like #-xFFFF80..., rather than #x-80... as it should be. There are extra 1 bits padding up to the bignum digit. These must be chopped away. --- arith.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arith.c b/arith.c index 7ebe0819..537c1a0d 100644 --- a/arith.c +++ b/arith.c @@ -2405,6 +2405,7 @@ val sign_extend(val n, val nbits) { val out = make_ubignum(); mp_2comp(mp(ntrunc), mp(out), mp(ntrunc)->used); + mp_trunc(mp(out), mp(out), c_num(nbits)); mp_neg(mp(out), mp(out)); return normalize(out); } -- cgit v1.2.3