diff options
| author | Arnold D. Robbins <arnold@skeeve.com> | 2022-02-22 20:12:28 +0200 |
|---|---|---|
| committer | Arnold D. Robbins <arnold@skeeve.com> | 2022-02-22 20:12:28 +0200 |
| commit | 80de2f7c9bc519fb820033a530e1657977117a33 (patch) | |
| tree | e0b8b01efe8040cdb7b5039d17aa93a85bc0b442 /extension | |
| parent | 938afb4d7acb9974d5789dfe4e322c0ccce0541e (diff) | |
| download | egawk-80de2f7c9bc519fb820033a530e1657977117a33.tar.gz egawk-80de2f7c9bc519fb820033a530e1657977117a33.tar.bz2 egawk-80de2f7c9bc519fb820033a530e1657977117a33.zip | |
Fix resource links found by Coverity.
Diffstat (limited to 'extension')
| -rw-r--r-- | extension/ChangeLog | 7 | ||||
| -rw-r--r-- | extension/readfile.c | 4 |
2 files changed, 10 insertions, 1 deletions
diff --git a/extension/ChangeLog b/extension/ChangeLog index fc90156f..69896748 100644 --- a/extension/ChangeLog +++ b/extension/ChangeLog @@ -1,3 +1,10 @@ +2022-02-22 Arnold D. Robbins <arnold@skeeve.com> + + Fix resource links found by Coverity. Thanks to + Jakub Martisko <jamartis@redhat.com> for the report. + + * readfile.c (do_readfile): Close fd if text == NULL. + 2021-12-10 Arnold D. Robbins <arnold@skeeve.com> * rwarray.c (write_number, read_number): Reformat comments a bit. diff --git a/extension/readfile.c b/extension/readfile.c index 6c3307cd..def414ee 100644 --- a/extension/readfile.c +++ b/extension/readfile.c @@ -121,8 +121,10 @@ do_readfile(int nargs, awk_value_t *result, struct awk_ext_func *unused) } text = read_file_to_buffer(fd, & sbuf); - if (text == NULL) + if (text == NULL) { + close(fd); goto done; /* ERRNO already updated */ + } close(fd); make_malloced_string(text, sbuf.st_size, result); |