diff options
| author | Kaz Kylheku <kaz@kylheku.com> | 2022-08-15 08:00:31 -0700 |
|---|---|---|
| committer | Kaz Kylheku <kaz@kylheku.com> | 2022-08-15 08:00:31 -0700 |
| commit | e55119040c31bb0870e73679239c9cdebc78a14c (patch) | |
| tree | eb69600525a14d1db3970eb0484c73f35e9d59cf | |
| parent | 50ff6bdedca1e4817c38f59d531aab875963bf2f (diff) | |
| download | ger2err-e55119040c31bb0870e73679239c9cdebc78a14c.tar.gz ger2err-e55119040c31bb0870e73679239c9cdebc78a14c.tar.bz2 ger2err-e55119040c31bb0870e73679239c9cdebc78a14c.zip | |
Simplify code in get-gerrit-comments.
- Don't capture info into variables that are accessed
only once and whose content is obvious *and* already
named by the struct slot.
| -rwxr-xr-x | ger2err | 23 |
1 files changed, 8 insertions, 15 deletions
@@ -78,29 +78,22 @@ (each ((cmt comments)) (let ((unresolved [cmt "unresolved"])) (when (or unresolved resolved-too) - (let* ((line (int-flo (or [cmt "line"] 0.0))) - (rng [cmt "range"]) - (endchr [rng "end_character"]) - (ps-num (int-flo [cmt "patch_set"])) - (auth [cmt "author"]) - (name [auth "name"]) - (username [auth "username"]) - (unresolved [cmt "unresolved"]) - (lines (spl "\n" [cmt "message"])) + (let* ((ps-num (int-flo [cmt "patch_set"])) (patch-set (or [ps-hash ps-num] (set [ps-hash ps-num] (new patch-set num ps-num)))) (file (or [patch-set.files path] (set [patch-set.files path] - (new file path path))))) + (new file path path)))) + (auth [cmt "author"])) (vec-push file.comments (new comment - line line - chr endchr + line (int-flo (or [cmt "line"] 0.0)) + chr [[cmt "range"] "end_character"] unresolved unresolved - user username - name name - lines lines))))))))) + user [auth "username"] + name [auth "name"] + lines (spl "\n" [cmt "message"])))))))))) (defun print-as-errors (patchset) (put-line `comments from patch set @{patchset.num}`) |