diff options
| author | Tomas Heinrich <theinric@redhat.com> | 2013-03-18 16:28:47 +0100 |
|---|---|---|
| committer | Rainer Gerhards <rgerhards@adiscon.com> | 2013-03-20 09:38:37 +0100 |
| commit | 8059afa9998906ba11d3509beff7af6f7efd9af1 (patch) | |
| tree | 15fd74b82254072961a7ae16b18e2a573debb628 | |
| parent | bb74c4485a5fcb938645ca513f7b592aceff1c7f (diff) | |
| download | rsyslog-8059afa9998906ba11d3509beff7af6f7efd9af1.tar.gz rsyslog-8059afa9998906ba11d3509beff7af6f7efd9af1.tar.bz2 rsyslog-8059afa9998906ba11d3509beff7af6f7efd9af1.zip | |
bugfix: get rid of potential endless loop in doGetGID()
| -rw-r--r-- | runtime/cfsysline.c | 28 |
1 files changed, 15 insertions, 13 deletions
diff --git a/runtime/cfsysline.c b/runtime/cfsysline.c index ad087652..bc5ffa6f 100644 --- a/runtime/cfsysline.c +++ b/runtime/cfsysline.c @@ -349,8 +349,9 @@ static rsRetVal doGetGID(uchar **pp, rsRetVal (*pSetHdlr)(void*, uid_t), void *p struct group gBuf; DEFiRet; uchar szName[256]; - int bufSize = 2048; + int bufSize = 1024; char * stringBuf = NULL; + int err; assert(pp != NULL); assert(*pp != NULL); @@ -360,20 +361,21 @@ static rsRetVal doGetGID(uchar **pp, rsRetVal (*pSetHdlr)(void*, uid_t), void *p ABORT_FINALIZE(RS_RET_NOT_FOUND); } - - CHKmalloc(stringBuf = malloc(bufSize)); - while(pgBuf == NULL) { - errno = 0; - getgrnam_r((char*)szName, &gBuf, stringBuf, bufSize, &pgBuf); - if((pgBuf == NULL) && (errno == ERANGE)) { - /* Increase bufsize and try again.*/ - bufSize *= 2; - CHKmalloc(stringBuf = realloc(stringBuf, bufSize)); - } - } + do { + /* Increase bufsize and try again.*/ + bufSize *= 2; + CHKmalloc(stringBuf = realloc(stringBuf, bufSize)); + err = getgrnam_r((char*)szName, &gBuf, stringBuf, bufSize, &pgBuf); + } while((pgBuf == NULL) && (err == ERANGE)); if(pgBuf == NULL) { - errmsg.LogError(0, RS_RET_NOT_FOUND, "ID for group '%s' could not be found or error", (char*)szName); + if (err != 0) { + rs_strerror_r(err, stringBuf, bufSize); + errmsg.LogError(0, RS_RET_NOT_FOUND, "Query for group '%s' resulted in an error: %s\n", + (char*)szName, stringBuf); + } else { + errmsg.LogError(0, RS_RET_NOT_FOUND, "ID for group '%s' could not be found", (char*)szName); + } iRet = RS_RET_NOT_FOUND; } else { if(pSetHdlr == NULL) { |