crypt: fix for platforms that lack crypt_r.

* sysif.c (crypt_wrap): Don't call free(cd) on platforms
where we don't have crypt_r and have not defined the
cd variable.

* test/018/crypt.tl: Move the (crypt "a" "b") test case
to be GNU/Linux-only. On Solaris, it yields a valid-looking
hash instead of failing. That hash will not validate the
password though; i.e. (crypt "a" (crypt "a" "b")) is not
equal to (crypt "a" "b").

1 files changed, 4 insertions, 0 deletions

diff --git a/sysif.c b/sysif.c
index 5af269d5..00354a10 100644
--- a/sysif.c
+++ b/sysif.c
@@ -2083,11 +2083,15 @@ static val crypt_wrap(val wkey, val wsalt)
 
   if (hash != 0) {
     val ret = string_utf8(hash);
+#if HAVE_CRYPT_R
     free(cd);
+#endif
     return ret;
   }
 
+#if HAVE_CRYPT_R
   free(cd);
+#endif
 
   uw_ethrowf(error_s, lit("crypt failed: ~d/~s"), num(errno),
              errno_to_str(errno), nao);